Page MenuHomePhabricator

Unpack draft object to key and text in commCoreModule updateDraft method signature
ClosedPublic

Authored by marcin on Nov 30 2022, 4:37 AM.
Tags
None
Referenced Files
F3255734: D5767.id19003.diff
Fri, Nov 15, 8:28 PM
Unknown Object (File)
Wed, Nov 6, 7:06 PM
Unknown Object (File)
Mon, Nov 4, 3:50 PM
Unknown Object (File)
Mon, Nov 4, 8:21 AM
Unknown Object (File)
Tue, Oct 22, 12:06 PM
Unknown Object (File)
Tue, Oct 22, 11:54 AM
Unknown Object (File)
Tue, Oct 22, 11:54 AM
Unknown Object (File)
Tue, Oct 22, 12:26 AM
Subscribers

Details

Summary

This differential addresses the following Linear urgent issue: https://linear.app/comm/issue/ENG-2374/jsi-codegen-broken-by-new-drafts-types. It is done by removing draft as argument type from updateDraft method and passing key and text directly.

Test Plan
  1. cd native && yarn codegen-jsi MUST work. 2. Launch flipper, type drafts, close the app. Open again and ensure that typped drafts are in the payload of setClientDBStore action. This way we simply ensure that modifying updateDraft on the C++ side didn't break draft-persistence functionality.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2374
Lint
No Lint Coverage
Unit
No Test Coverage