[web] Keyboard support for typeahead [9/13] - Refactor getTypeaheadTooltipButtons as a function
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:57 AM.

Details

Reviewers

inka
kamil
ginsu
tomek

Commits

rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor…

Summary

Moved creating buttons in overlay to utility function.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• przemek created this revision.Dec 27 2022, 4:57 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:57 AM

Harbormaster completed remote builds in B14783: Diff 20162.Dec 27 2022, 5:11 AM

• przemek requested review of this revision.Dec 27 2022, 5:11 AM

• przemek added a parent revision: D6048: [web] Keyboard support for typeahead [8/13] - Add positive modulo function.Dec 27 2022, 5:31 AM

• przemek added a child revision: D6050: [web] Keyboard support for typeahead [10/13] - Create and set callback functions in tooltip component. It does not do anything yet.

inka accepted this revision.Dec 28 2022, 7:08 AM

inka added a reviewer: tomek.

Why do you move it?

This revision is now accepted and ready to land.Dec 30 2022, 9:19 AM

It felt cleaner to has it closed in utils funtion.

Closed by commit rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor… (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM

This revision was automatically updated to reflect the committed changes.

• przemek added a commit: rCOMM84aef4c58dca: [web] Keyboard support for typeahead [9/13] - Refactor….

Revision Contents
Changeset List

Path

Size

web/

chat/

typeahead-tooltip.react.js

13 lines

utils/

typeahead-utils.js

13 lines

Diff 20162

View Options

web/chat/typeahead-tooltip.react.js