add localID field to reaction message type. We are going to need this to create local reaction messages which we will display optimistically
Linear Task: ENG-2519
Differential D6117
[lib] add localID field to reaction message type Authored by ginsu on Dec 30 2022, 11:38 PM.
Details add localID field to reaction message type. We are going to need this to create local reaction messages which we will display optimistically Linear Task: ENG-2519 flow and will be testing more in subsequent diffs
Diff Detail
Event TimelineComment Actions I wonder if this should be LocallyComposedMessageInfo. Looks like it's only use for CREATE_LOCAL_MESSAGE. Should we use that for reactions at all? Comment Actions It sounds a little strange to say that reaction message is composable, but it shares a lot of properties with other composable message types, so I think it makes sense to include it in this set. Comment Actions Are we gonna use CREATE_LOCAL_MESSAGE for reactions? Guessing no, but I guess it didn't hurt to update LocallyComposedMessageInfo anyways Comment Actions
That is correct, we won't but since they share many similar properties, I figured adding it made sense |