Details

Reviewers

Commits

rCOMMfee7aa83830a: [web] Add subchannels button

Summary

Add a button that will be used in community drawer for navigating to chats subchannels modal.
Related issue
The same button on native: D6001

Test Plan

Added button to ChatThreadListItem and checked that pressing it opens the subchannels modal

Diff Detail

Repository

rCOMM Comm

Branch

inka/community_drawer_web

Lint

No Lint Coverage

Unit

No Test Coverage

inka edited the summary of this revision. (Show Details)Jan 4 2023, 5:09 AM

inka edited the summary of this revision. (Show Details)Jan 4 2023, 5:18 AM

inka requested review of this revision.Jan 4 2023, 5:22 AM

web/sidebar/subchannels-button.react.js
30–37	A lot of wrappers here, can't we simplify it?

Remove wrapper. Turns out it didn't do anything...

web/sidebar/subchannels-button.react.js
30–37	I should have given `className={css.wrapper}` to `Button`, but actually I tested it and somehow it's not needed... So going to just remove the wrapper

web/sidebar/subchannels-button.css
1–18 ↗	(On Diff #20675)	I think we should use hardcoded font sizes/weights. Check `web/typography.css` for available css variables.;

use web/typography.css values

Rebase

Looks great apart from text color concern

web/sidebar/subchannels-button.css
15 ↗	(On Diff #21076)	Why is this color so dark? Correct me if I'm wrong, but in designs we're using white for that: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7332%3A144407&t=VHPLMWEzFLtTEfig-0 It might be the case that I missed something in discussion between you and designers

This revision is now accepted and ready to land.Jan 26 2023, 3:40 AM

web/sidebar/subchannels-button.css
15 ↗	(On Diff #21076)	That was written couple of design iterations ago, when this was the colour used for this button. The designs keep changing, and because of that I will revisit all of styling in this issue, at the end of implementing the drawer.