Paths

Table of Contentst

[keyserver] move logic to fetch not acknowledged policies to separate function
ClosedPublic
Actions

Authored by kamil on Dec 29 2022, 4:24 AM.

Details

Reviewers

inka
michal
• przemek

Commits

rCOMMa027ed5d94af: [keyserver] move logic to fetch not acknowledged policies to separate function

Summary

This is just a refactor, in next diffs I'll introduce changes that will require checking for not acknowledged policies and this will make possible to avoid try {} catch () {} pattern by using simple function call and improve readability.

Test Plan

Maintain previous functionality of this function

Diff Detail

Repository

rCOMM Comm

Branch

policy-stuff-10

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 29 2022, 4:24 AM

kamil held this revision as a draft.

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 29 2022, 4:24 AM

Harbormaster failed remote builds in B14905: Diff 20322!Dec 29 2022, 4:27 AM

kamil added a child revision: D6092: [lib] validate policies after user login.Dec 29 2022, 4:33 AM

kamil published this revision for review.Dec 29 2022, 5:24 AM

kamil added a parent revision: D5875: [lib] validate policies after user login.

rebase

Harbormaster completed remote builds in B15221: Diff 20751.Jan 10 2023, 7:44 AM

inka accepted this revision.Jan 11 2023, 2:55 AM

This revision is now accepted and ready to land.Jan 11 2023, 2:55 AM

Closed by commit rCOMMa027ed5d94af: [keyserver] move logic to fetch not acknowledged policies to separate function (authored by kamil). · Explain WhyJan 20 2023, 1:38 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa027ed5d94af: [keyserver] move logic to fetch not acknowledged policies to separate function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

policy-acknowledgment-fetchers.js

18 lines

utils/

validation-utils.js

10 lines

Diff 20751

View Options

keyserver/src/fetchers/policy-acknowledgment-fetchers.js