Page MenuHomePhabricator
Differential D6045

[web] Keyboard support for typeahead [5/13] - Moved finding suggested users out of tooltip component
ClosedPublic
Actions

Authored by • przemek on Dec 27 2022, 4:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 8:29 AM
Unknown Object (File)
Sat, Oct 26, 8:54 AM
Unknown Object (File)
Mon, Oct 14, 10:48 PM
Unknown Object (File)
Fri, Oct 4, 2:23 PM
Unknown Object (File)
Sep 28 2024, 2:02 PM
Unknown Object (File)
Sep 28 2024, 2:02 PM
Unknown Object (File)
Sep 28 2024, 2:02 PM
Unknown Object (File)
Sep 28 2024, 2:01 PM
View All Files
Subscribers
ashoat
atul
ginsu
inka
kamil
tomek

Details

Reviewers
inka
kamil
ginsu
tomek
Commits
rCOMMd7f2decc2753: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out…
Summary

I moved logic user search out of tooltip component. It allows to simplify component and its rendering logic.
Now we only show overlay if we find any users in thread matching typed text.

Test Plan

Typeahead without keyboard support works.
Final tests performed in last diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• przemek created this revision.Dec 27 2022, 4:45 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 27 2022, 4:45 AM
Harbormaster completed remote builds in B14778: Diff 20156.Dec 27 2022, 4:59 AM
• przemek requested review of this revision.Dec 27 2022, 4:59 AM
• przemek added a parent revision: D6044: [web] Keyboard support for typeahead [4/13] - Renamed regex.Dec 27 2022, 5:30 AM
• przemek added a child revision: D6046: [web] Keyboard support for typeahead [6/13] - Get rid of entire text and rename matched strings.
ashoat added inline comments.Dec 27 2022, 12:27 PM
web/chat/chat-input-bar.react.js
562–571 ↗(On Diff #20156)

Early exit always please. Please keep this in mind going forward!

• przemek updated this revision to Diff 20387.Dec 29 2022, 12:04 PM

Returned early.

Harbormaster completed remote builds in B14946: Diff 20387.Dec 29 2022, 12:18 PM
inka accepted this revision.Dec 30 2022, 2:10 AM
inka added a reviewer: tomek.
tomek accepted this revision.Dec 30 2022, 8:33 AM

Nice!

This revision is now accepted and ready to land.Dec 30 2022, 8:33 AM
Closed by commit rCOMMd7f2decc2753: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out… (authored by • przemek). · Explain WhyJan 12 2023, 6:21 AM
This revision was automatically updated to reflect the committed changes.
• przemek added a commit: rCOMMd7f2decc2753: [web] Keyboard support for typeahead [5/13] - Moved finding suggested users out….

Revision Contents
Changeset List

PathSize
lib/
shared/
13 lines
web/
chat/
35 lines
30 lines

Diff 20863

View Options

lib/shared/typeahead-utils.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/chat/typeahead-tooltip.react.js

Loading...