Paths

Table of Contentst

Differential D6571

[lib][keyserver] Convert notificationTexts to async functions
ClosedPublic
Actions

Authored by ashoat on Feb 3 2023, 4:14 PM.

Tags

None

Referenced Files

	F2847236: D6571.id22033.diff
	Mon, Sep 30, 2:27 AM

	F2846833: D6571.diff
	Mon, Sep 30, 12:31 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:19 AM

	Unknown Object (File)
	Thu, Sep 26, 8:13 AM

	Unknown Object (File)
	Mon, Sep 16, 12:43 PM

View All 86 Files

Subscribers

Details

Reviewers

ginsu
atul
michal
marcin

Commits

rCOMM39896e990789: [lib][keyserver] Convert notificationTexts to async functions

Summary

This will allow us to handle ENS resolution there. We'll probably actually do that outside of notificationTexts (probably in fullNotifTextsForMessageInfo), but it's probably good to make notificationTexts async as well (for eg. @ginsu's planned work on reactions notifs).

Test Plan

Flow

Diff Detail

Repository

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 3 2023, 4:14 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 3 2023, 4:14 PM

Harbormaster completed remote builds in B16085: Diff 21972.Feb 3 2023, 4:28 PM

ashoat requested review of this revision.Feb 3 2023, 4:28 PM

ashoat added a child revision: D6572: [keyserver] Base setup of ethers.js and ENSCache.Feb 4 2023, 9:58 AM

atul accepted this revision.Feb 4 2023, 11:33 AM

This revision is now accepted and ready to land.Feb 4 2023, 11:33 AM

Return delivery object from new async IIFE

Harbormaster completed remote builds in B16141: Diff 22033.Feb 5 2023, 7:45 AM

Closed by commit rCOMM39896e990789: [lib][keyserver] Convert notificationTexts to async functions (authored by ashoat). · Explain WhyFeb 5 2023, 7:53 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM39896e990789: [lib][keyserver] Convert notificationTexts to async functions.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

68 lines

lib/

shared/

messages/

add-members-message-spec.js

4 lines

change-role-message-spec.js

4 lines

change-settings-message-spec.js

4 lines

create-entry-message-spec.js

4 lines

create-sidebar-message-spec.js

4 lines

create-sub-thread-message-spec.js

4 lines

create-thread-message-spec.js

4 lines

delete-entry-message-spec.js

4 lines

edit-entry-message-spec.js

4 lines

join-thread-message-spec.js

4 lines

leave-thread-message-spec.js

4 lines

message-spec.js

4 lines

multimedia-message-spec.js

4 lines

reaction-message-spec.js

4 lines

remove-members-message-spec.js

4 lines

restore-entry-message-spec.js

4 lines

sidebar-source-message-spec.js

6 lines

text-message-spec.js

4 lines

update-relationship-message-spec.js

4 lines

15 lines

Diff 21972

keyserver/src/push/send.js

Loading...

lib/shared/messages/add-members-message-spec.js

Loading...

lib/shared/messages/change-role-message-spec.js

Loading...

lib/shared/messages/change-settings-message-spec.js

Loading...

lib/shared/messages/create-entry-message-spec.js

Loading...

lib/shared/messages/create-sidebar-message-spec.js

Loading...

lib/shared/messages/create-sub-thread-message-spec.js

Loading...

lib/shared/messages/create-thread-message-spec.js

Loading...

lib/shared/messages/delete-entry-message-spec.js

Loading...

lib/shared/messages/edit-entry-message-spec.js

Loading...

lib/shared/messages/join-thread-message-spec.js

Loading...

lib/shared/messages/leave-thread-message-spec.js

Loading...

lib/shared/messages/message-spec.js

Loading...

lib/shared/messages/multimedia-message-spec.js

Loading...

lib/shared/messages/reaction-message-spec.js

Loading...

lib/shared/messages/remove-members-message-spec.js

Loading...

lib/shared/messages/restore-entry-message-spec.js

Loading...

lib/shared/messages/sidebar-source-message-spec.js

Loading...

lib/shared/messages/text-message-spec.js

Loading...

lib/shared/messages/update-relationship-message-spec.js

Loading...

lib/shared/notif-utils.js

Loading...