Add buttons to be used in community drawer to expand items.
Related issue
The same buttons on native : D5718
Details
Details
- Reviewers
• przemek michal ginsu tomek - Commits
- rCOMMdb464b3a31bf: [web] Add expand buttons
Displayed buttons in AppSwitcher, checked that they display as expected and onClick works
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Is there a reason why we don't just have a disabled property in props?
| web/sidebar/expand-buttons.react.js | ||
|---|---|---|
| 20–26 ↗ | (On Diff #20564) | .buttonWrapper {
font-size: 12px;
width: 24px;
height: 24px;
}Could this be simplified to something like this? |
| web/sidebar/expand-buttons.react.js | ||
|---|---|---|
| 12 ↗ | (On Diff #20564) | We should use mixed. See: https://phab.comm.dev/D6047?id=20388#inline-41131 |
| 30–36 ↗ | (On Diff #20564) | You can pass disabled props to ExpandButton and then to Button and create conditional style based on it if needed. |
| web/sidebar/expand-buttons.css | ||
|---|---|---|
| 10 ↗ | (On Diff #20673) | Please use a constant from typography.css. |