Page MenuHomePhabricator
Differential D6869

[lib] Collapse CreateSidebar and SidebarSource notifs together
ClosedPublic
Actions

Authored by ashoat on Feb 23 2023, 1:12 PM.
Tags
None
Referenced Files
F3512174: D6869.diff
Sat, Dec 21, 6:32 PM
Unknown Object (File)
Sat, Nov 23, 3:52 PM
Unknown Object (File)
Oct 27 2024, 1:54 PM
Unknown Object (File)
Oct 18 2024, 5:43 PM
Unknown Object (File)
Oct 18 2024, 5:16 AM
Unknown Object (File)
Oct 18 2024, 5:16 AM
Unknown Object (File)
Oct 18 2024, 5:16 AM
Unknown Object (File)
Sep 27 2024, 5:56 PM
View All 98 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM73d7ff10b795: [lib] Collapse CreateSidebar and SidebarSource notifs together
Summary

Before this diff, SidebarSource did not generate any notifs, and CreateSidebar did.

After this diff, technically SidebarSource generates a notif... but not really. Since SidebarSource and CreateSidebar get collapsed into each other, and CreateSidebar is the more recent message, AND the two messages are always generated together on the keyserver... the result is that they only ever generate one notif for the both of them.

The only reason for this is that I want to have access to the SidebarSource message in CreateSidebar's notificationTexts function so that I can check it for @-mentions.

Depends on D6868

Test Plan

In combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 23 2023, 1:12 PM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 23 2023, 1:12 PM
ashoat added a child revision: D6870: [lib] Add invariant to SidebarSource notificationTexts.Feb 23 2023, 1:14 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2023, 1:37 PM
Harbormaster failed remote builds in B16850: Diff 23029!
Harbormaster completed remote builds in B16850: Diff 23029.Feb 23 2023, 2:24 PM
ashoat requested review of this revision.Feb 23 2023, 2:24 PM
atul accepted this revision.Feb 24 2023, 11:50 PM
This revision is now accepted and ready to land.Feb 24 2023, 11:50 PM
Closed by commit rCOMM73d7ff10b795: [lib] Collapse CreateSidebar and SidebarSource notifs together (authored by ashoat). · Explain WhyFeb 27 2023, 3:56 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM73d7ff10b795: [lib] Collapse CreateSidebar and SidebarSource notifs together.
ashoat mentioned this in D7085: [native] Add a C++ MessageSpec for SidebarSource.Mar 16 2023, 1:43 PM
ashoat mentioned this in rCOMM7faf93694def: [native] Add a C++ MessageSpec for SidebarSource.Mar 16 2023, 2:01 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
5 lines
19 lines

Diff 23029

View Options

lib/shared/messages/create-sidebar-message-spec.js

Loading...
View Options

lib/shared/messages/sidebar-source-message-spec.js

Loading...