[keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override
ClosedPublic
Actions

Authored by ashoat on Feb 23 2023, 1:11 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMa0927c1d5c85: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override

Summary

If somebody starts a sidebar from a message that has an @-mention, we want to override the @-mentioned user's notifs for the sidebar creation.

Depends on D6866

Test Plan

In combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 23 2023, 1:11 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 23 2023, 1:11 PM

ashoat added a child revision: D6868: [lib] Allow multiple messages in CreateSidebar notificationTexts.Feb 23 2023, 1:12 PM

Harbormaster completed remote builds in B16848: Diff 23027.Feb 23 2023, 1:27 PM

ashoat requested review of this revision.Feb 23 2023, 1:27 PM

atul accepted this revision.Feb 24 2023, 2:33 AM

This revision is now accepted and ready to land.Feb 24 2023, 2:33 AM

Closed by commit rCOMMa0927c1d5c85: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override (authored by ashoat). · Explain WhyFeb 27 2023, 3:56 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa0927c1d5c85: [keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif override.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

15 lines

Diff 23194

View Options

keyserver/src/push/send.js

[keyserver] Check SIDEBAR_SOURCE's source message for @-mention notif overrideClosedPublicActions