Page MenuHomePhabricator
Differential D7090

Unit tests for Olm's new X3DH methods
ClosedPublic
Actions

Authored by ashoat on Mar 16 2023, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:27 PM
Unknown Object (File)
Sat, Dec 14, 4:26 PM
Unknown Object (File)
Sat, Dec 14, 4:18 PM
View All Files
Subscribers
atul
bartek
tomek

Details

Reviewers
anunay
• jon
varun
bartek
Commits
rCOMM4be48ba24af2: Unit tests for Olm's new X3DH methods
Summary

This adds a quick test test to confirm Anunay's new methods work on web and keyserver that are introduced in the [fork](D7089).

Note that more extensive testing was done by updating the upstream tests in the fork, which include a Bob/Alice scenario in JavaScript.

Depends on D7091

Test Plan

Run the tests

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/olm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Mar 16 2023, 6:54 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptMar 16 2023, 6:54 PM
ashoat mentioned this in D7089: [web][keyserver] Fork Olm.Mar 16 2023, 6:56 PM
ashoat added a reviewer: bartek.
ashoat added a subscriber: bartek.
ashoat added inline comments.
keyserver/jest-setup.js
1–8 ↗(On Diff #23811)

This is copied from web/jest-setup.js, introduced in D7019 by @bartek

ashoat mentioned this in D7083: Amended Account & Session types..Mar 16 2023, 6:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2023, 7:04 PM
Harbormaster failed remote builds in B17378: Diff 23811!
ashoat mentioned this in D7091: [native] Fork Olm.Mar 16 2023, 7:34 PM
ashoat edited parent revisions, added: D7091: [native] Fork Olm; removed: D7089: [web][keyserver] Fork Olm.Mar 16 2023, 7:34 PM
ashoat updated this revision to Diff 23814.Mar 16 2023, 7:34 PM
ashoat added a parent revision: D7089: [web][keyserver] Fork Olm.

Rebase

Harbormaster completed remote builds in B17381: Diff 23814.Mar 16 2023, 7:50 PM
ashoat requested review of this revision.Mar 16 2023, 7:50 PM
ashoat removed a parent revision: D7089: [web][keyserver] Fork Olm.Mar 16 2023, 7:55 PM
ashoat updated this revision to Diff 23817.Mar 16 2023, 8:03 PM
ashoat added a parent revision: D7089: [web][keyserver] Fork Olm.

Rebase

ashoat edited the summary of this revision. (Show Details)Mar 16 2023, 8:03 PM
ashoat edited the summary of this revision. (Show Details)
ashoat removed a parent revision: D7089: [web][keyserver] Fork Olm.
Harbormaster completed remote builds in B17384: Diff 23817.Mar 16 2023, 8:18 PM
bartek accepted this revision.Mar 21 2023, 4:37 AM
bartek added inline comments.
keyserver/src/utils/olm-utils.test.js
18 ↗(On Diff #23817)

You can possibly use toBeDefined or toBeTruthy here but up to you

This revision is now accepted and ready to land.Mar 21 2023, 4:37 AM
ashoat updated this revision to Diff 24901.Apr 10 2023, 9:46 AM

Rebase

Harbormaster failed remote builds in B18187: Diff 24901!Apr 10 2023, 10:03 AM
ashoat updated this revision to Diff 24904.Apr 10 2023, 10:04 AM

Use toBeDefined(), rebase

Harbormaster completed remote builds in B18190: Diff 24904.Apr 10 2023, 10:21 AM
Closed by commit rCOMM4be48ba24af2: Unit tests for Olm's new X3DH methods (authored by ashoat). · Explain WhyApr 10 2023, 10:22 AM
This revision was automatically updated to reflect the committed changes.
ashoat mentioned this in rCOMMc703140bc275: [web][keyserver] Fork Olm.
ashoat mentioned this in rCOMM88f39387453f: [native] Fork Olm.
ashoat added a commit: rCOMM4be48ba24af2: Unit tests for Olm's new X3DH methods.
ashoat mentioned this in D7372: [web] Use toBeDefined in web Olm tests.Apr 10 2023, 10:38 AM
ashoat mentioned this in rCOMMe8e2957141fc: [web] Use toBeDefined in web Olm tests.Apr 10 2023, 11:41 AM

Revision Contents
Changeset List

PathSize
keyserver/
8 lines
3 lines
src/
utils/
7 lines
web/
olm/
7 lines

Diff 23814

View Options

keyserver/jest-setup.js

Loading...
View Options

keyserver/package.json

Loading...
View Options

keyserver/src/utils/olm-utils.test.js

Loading...
View Options

web/olm/olm.test.js

Loading...