Details

Reviewers

anunay
• jon
varun
atul
bartek
tomek

Commits

rCOMMc703140bc275: [web][keyserver] Fork Olm

Summary

This switches us over to using a fork of Olm latest.

The fork is mostly Anunay's work to add X3DH support, plus @jon's work to add Nix build support for macOS, plus some fixes from me.

To review this you'll probably want to check the fork's commit history on GitHub. We should probably set up some way to review the stuff in the fork, but I'm not sure what the best approach is yet. For now, I've left comments directly on @anunay's commit on GitHub.

Test Plan

Unit tests are added in D7090
Also note that we successfully ran Olm C++ and JS test suites
I also patched the web app to confirm it worked

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 16 2023, 6:33 PM

ashoat added a parent revision: D7083: Amended Account & Session types..Mar 16 2023, 6:41 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 16 2023, 6:44 PM

Harbormaster failed remote builds in B17376: Diff 23809!

ashoat added a child revision: D7090: Unit tests for Olm's new X3DH methods.Mar 16 2023, 6:54 PM

RE CI failure, looks like we need to update the xcode folder in the fork as well. Will publish this for review for now, but will definitely make sure to fix the xcode folder before landing

ashoat edited the test plan for this revision. (Show Details)Mar 16 2023, 6:56 PM

ashoat mentioned this in D7083: Amended Account & Session types..Mar 16 2023, 6:59 PM

ashoat retitled this revision from Fork Olm to [web][keyserver] Fork Olm.Mar 16 2023, 7:33 PM

Pull out the native work

ashoat added a child revision: D7091: [native] Fork Olm.Mar 16 2023, 7:34 PM

ashoat removed a child revision: D7090: Unit tests for Olm's new X3DH methods.Mar 16 2023, 7:34 PM

ashoat added a child revision: D7090: Unit tests for Olm's new X3DH methods.Mar 16 2023, 7:34 PM

Pulled out native side to D7091 since it turned out to be more work than expected

Harbormaster completed remote builds in B17379: Diff 23812.Mar 16 2023, 7:49 PM

ashoat removed a child revision: D7090: Unit tests for Olm's new X3DH methods.Mar 16 2023, 7:55 PM

Update to 0.0.2... it doesn't actually affect web or keyserver, but I figure it's better to do it

ashoat added a child revision: D7090: Unit tests for Olm's new X3DH methods.Mar 16 2023, 8:03 PM