Paths

Table of Contentst

[web] render user avatars in message reactions modal
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 7:29 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMMb9345d30110d: [web] render user avatars in message reactions modal

Summary

render user avatars in message reactions modal

This diff won't be landed until avatars is given the green light to be released

Depends on D7195

Test Plan

Please see the screenshot below to see the changes I made

Before:

Screenshot 2023-03-27 at 5.53.19 PM.png (2×3 px, 844 KB)

After:

Screenshot 2023-03-27 at 5.54.08 PM.png (2×3 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2023, 7:29 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 7:29 AM

Harbormaster completed remote builds in B17682: Diff 24205.Mar 27 2023, 7:45 AM

ginsu requested review of this revision.Mar 27 2023, 7:45 AM

ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 2:58 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7195: [web] render user avatars in chat screen.

ginsu attached a referenced file: F448403: Screenshot 2023-03-27 at 5.54.08 PM.png. (Show Details)

ginsu attached a referenced file: F448401: Screenshot 2023-03-27 at 5.53.19 PM.png. (Show Details)

ginsu added a child revision: D7205: [web] render user avatars in account relationship lists.Mar 27 2023, 3:53 PM

Hmm it seems like we'll need to refactor this after getAvatarForUser gets converted to a hook (see my chat message)

atul accepted this revision.Mar 28 2023, 1:09 PM

This revision is now accepted and ready to land.Mar 28 2023, 1:09 PM

replace Avatar with UserAvatar

Harbormaster completed remote builds in B17909: Diff 24539.Apr 3 2023, 1:47 AM

rebase before landing

Harbormaster completed remote builds in B17969: Diff 24606.Apr 4 2023, 11:19 AM

Closed by commit rCOMMb9345d30110d: [web] render user avatars in message reactions modal (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMb9345d30110d: [web] render user avatars in message reactions modal.

Revision Contents
Changeset List

Path

Size

web/

modals/

chat/

message-reactions-modal.css

10 lines

message-reactions-modal.react.js

21 lines

Diff 24205

View Options

web/modals/chat/message-reactions-modal.css