Page MenuHomePhabricator
Differential D7206

[web] render user avatars in chat thread composer
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 3:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 3:07 AM
Unknown Object (File)
Sun, Apr 28, 7:30 PM
Unknown Object (File)
Sat, Apr 27, 11:54 PM
Unknown Object (File)
Sat, Apr 27, 11:53 PM
Unknown Object (File)
Sat, Apr 27, 11:53 PM
Unknown Object (File)
Sat, Apr 27, 11:53 PM
Unknown Object (File)
Sat, Apr 27, 11:53 PM
Unknown Object (File)
Sat, Apr 27, 11:50 PM
View All 62 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMaee0ffc77d0c: [web] render user avatars in chat thread composer
Summary

render user avatas in chat thread composer

This diff won't be landed until avatars is given the green light to be released

Depends on D7205

Test Plan

Please see the screenshots to see the changes I made

Before:

Screenshot 2023-03-27 at 6.57.11 PM.png (2×3 px, 823 KB)

After:

Screenshot 2023-03-27 at 6.57.21 PM.png (2×3 px, 839 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2023, 3:58 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 3:58 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:01 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu added a parent revision: D7205: [web] render user avatars in account relationship lists.
ginsu attached a referenced file: F448523: Screenshot 2023-03-27 at 6.57.21 PM.png. (Show Details)
ginsu attached a referenced file: F448522: Screenshot 2023-03-27 at 6.57.11 PM.png. (Show Details)
ginsu added a child revision: D7207: [web] render user avatars in thread memebers modal.Mar 27 2023, 4:08 PM
Harbormaster completed remote builds in B17712: Diff 24245.Mar 27 2023, 4:14 PM
ginsu requested review of this revision.Mar 27 2023, 4:14 PM
ashoat added inline comments.Mar 27 2023, 4:41 PM
web/chat/chat-thread-composer.react.js
99–121 ↗(On Diff #24245)

I personally don't love seeing logic inline in JSX like this... can we move this out above line 97?

atul accepted this revision.Mar 28 2023, 1:20 PM

(Please address @ashoat's feedback before landing)

This revision is now accepted and ready to land.Mar 28 2023, 1:20 PM
ginsu updated this revision to Diff 24541.Apr 3 2023, 1:33 AM
ginsu edited the test plan for this revision. (Show Details)

replace Avatar with UserAvatar

ginsu updated this revision to Diff 24542.Apr 3 2023, 1:40 AM

removed inline JSX logic

Harbormaster completed remote builds in B17911: Diff 24541.Apr 3 2023, 1:49 AM
Harbormaster completed remote builds in B17912: Diff 24542.Apr 3 2023, 1:56 AM
ginsu updated this revision to Diff 24608.Apr 4 2023, 11:05 AM

rebase before landing

Harbormaster completed remote builds in B17971: Diff 24608.Apr 4 2023, 11:22 AM
Closed by commit rCOMMaee0ffc77d0c: [web] render user avatars in chat thread composer (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMaee0ffc77d0c: [web] render user avatars in chat thread composer.

Revision Contents
Changeset List

Diff 24541

View Options

web/chat/chat-thread-composer.css

Loading...
View Options

web/chat/chat-thread-composer.react.js

Loading...