[native] add edit avatar badge to thread avatar
ClosedPublic
Actions

Authored by ginsu on Apr 10 2023, 12:46 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM5bd1e72ccc56: [native] add edit avatar badge to thread avatar

Summary

add edit avatar badge to thread avatar. Most of this code was ported over from profile-screen.react.js; however, with thread avatars we need to make sure that this badge renders conditonally, since there are some threads where the user should not be allowed to edit thread avatar, whereas a user avatar can always be edited by the user

Depends on D7359

Test Plan

Please see the screenshots to see the changes I made:

Screenshot 2023-04-10 at 3.43.52 PM.png (1×1 px, 817 KB)

Personal Threads:

Screenshot 2023-04-10 at 3.44.15 PM.png (1×1 px, 813 KB)

Private Thread:

Screenshot 2023-04-10 at 3.44.02 PM.png (1×1 px, 819 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 10 2023, 12:46 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 10 2023, 12:46 PM

ginsu edited the summary of this revision. (Show Details)Apr 10 2023, 12:48 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.

ginsu edited the summary of this revision. (Show Details)

ginsu attached a referenced file: F476548: Screenshot 2023-04-10 at 3.44.02 PM.png. (Show Details)

ginsu attached a referenced file: F476547: Screenshot 2023-04-10 at 3.44.15 PM.png. (Show Details)

ginsu attached a referenced file: F476546: Screenshot 2023-04-10 at 3.43.52 PM.png. (Show Details)

Harbormaster completed remote builds in B18202: Diff 24926.Apr 10 2023, 1:02 PM

ginsu requested review of this revision.Apr 10 2023, 1:02 PM

Please do not land if this could potentially lead to us publishing a build that has a button that does nothing

native/chat/settings/thread-settings-avatar.react.js
23–24 ↗	(On Diff #24926)	It appears that this diff introduces a button that does nothing. Is this safe to land? Are you gating it some way, or are you going to wait to land it until this is addressed?

This revision is now accepted and ready to land.Apr 10 2023, 1:27 PM

ginsu added inline comments.Apr 10 2023, 1:32 PM

native/chat/settings/thread-settings-avatar.react.js
23–24 ↗	(On Diff #24926)	Atm this entire component is gated behind the feature flag, and won't be rendered. Happy to hold off on landing tho until the stack is landed

ashoat added inline comments.Apr 10 2023, 1:43 PM

native/chat/settings/thread-settings-avatar.react.js
23–24 ↗	(On Diff #24926)	Feature flag sounds good! Big point of the feature flags service was to make it easier for devs to land changes like this, so I think you should feel free to land