Page MenuHomePhabricator
Differential D7427

[native] introduce useSaveThreadAvatar hook
ClosedPublic
Actions

Authored by ginsu on Apr 13 2023, 10:02 AM.
Tags
None
Referenced Files
F2171325: D7427.id25180.diff
Tue, Jul 2, 5:45 PM
F2171214: D7427.id25180.diff
Tue, Jul 2, 5:21 PM
F2171164: D7427.id25173.diff
Tue, Jul 2, 5:10 PM
F2170971: D7427.id25131.diff
Tue, Jul 2, 4:32 PM
Unknown Object (File)
Sun, Jun 30, 8:51 PM
Unknown Object (File)
Sun, Jun 23, 12:05 PM
Unknown Object (File)
Sat, Jun 22, 8:48 AM
Unknown Object (File)
Fri, Jun 21, 4:40 AM
View All 49 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMaf21cf8f11cb: [native] introduce useSaveThreadAvatar hook
Summary

Similar logic to D7424 but for thread avatars

Depends on D7426

Test Plan

Able to save a thread avatar and double checked that the avatar column for the correct thread in the threads table was being populated

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 13 2023, 10:02 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 10:02 AM
ginsu edited the summary of this revision. (Show Details)Apr 13 2023, 10:03 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.
ginsu attached a referenced file: F483963: Screen Recording 2023-04-13 at 12.48.16 PM.mov. (Show Details)
Harbormaster completed remote builds in B18340: Diff 25131.Apr 13 2023, 10:20 AM
ginsu requested review of this revision.Apr 13 2023, 10:20 AM
ginsu added a child revision: D7428: [native] extend emoji avatar creation to handle thread avatars.Apr 13 2023, 10:27 AM
ashoat accepted this revision.Apr 14 2023, 6:39 AM
This revision is now accepted and ready to land.Apr 14 2023, 6:39 AM
ginsu updated this revision to Diff 25173.Apr 14 2023, 11:05 AM

rebase before landing

Harbormaster completed remote builds in B18375: Diff 25173.Apr 14 2023, 11:23 AM
Closed by commit rCOMMaf21cf8f11cb: [native] introduce useSaveThreadAvatar hook (authored by ginsu). · Explain WhyApr 14 2023, 11:33 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMaf21cf8f11cb: [native] introduce useSaveThreadAvatar hook.

Revision Contents
Changeset List

PathSize
native/
utils/
47 lines

Diff 25180

View Options

native/utils/avatar-utils.js

Loading...