Page MenuHomePhabricator
Differential D7506

[native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
ClosedPublic
Actions

Authored by atul on Apr 18 2023, 2:32 PM.
Tags
None
Referenced Files
F2714219: D7506.id25314.diff
Mon, Sep 16, 1:43 AM
F2714154: D7506.id25353.diff
Mon, Sep 16, 1:41 AM
Unknown Object (File)
Sun, Sep 8, 9:23 AM
Unknown Object (File)
Sun, Sep 8, 9:23 AM
Unknown Object (File)
Sun, Sep 8, 9:23 AM
Unknown Object (File)
Sun, Sep 8, 9:21 AM
Unknown Object (File)
Fri, Sep 6, 7:32 AM
Unknown Object (File)
Aug 16 2024, 5:09 PM
View All 57 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM45d2bc435f8a: [native] Pull `useShowAvatarActionSheet` out of `Edit*Avatar`
Summary

Pulling out some more logic that's in common between EditUserAvatar and EditThreadAvatar.

NOTE: One more quick refactor to tidy up editAvatarOptions and then we're gooing to move UserAvatar and ThreadAvatar "inside" Edit*Avatar components instead of just passing in React.Node.
Test Plan

Action sheet appears as it did previously + ESLint + Flow

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
avatars/
57 lines
50 lines
50 lines

Diff 25314

View Options

native/avatars/avatar-hooks.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/edit-user-avatar.react.js

Loading...