[blob-service] Set up CORS
ClosedPublic
Actions

Authored by bartek on Apr 29 2023, 9:12 AM.

Details

Reviewers

tomek
• jon
varun
ashoat

Commits

rCOMM2a42a7dad94a: [blob-service] Set up CORS

Summary

Details in ENG-3820 - we need to set up CORS for blob service to work on web.

Test Plan

Made GET and POST/PUT blob service requests from localhost web client ant from native. Tested both local sandbox and production service.
Without this change, the requests fail with CORS errors on web, they're fine on native.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 29 2023, 9:12 AM

bartek held this revision as a draft.

Herald added a subscriber: atul. · View Herald TranscriptApr 29 2023, 9:12 AM

bartek added a child revision: D7689: [web] Add function to upload media to Blob service.Apr 29 2023, 9:20 AM

bartek published this revision for review.Apr 29 2023, 9:24 AM

Harbormaster completed remote builds in B18937: Diff 25936.Apr 29 2023, 9:29 AM

New dependency looks good. Not familiar with Rust

• jon accepted this revision.May 1 2023, 12:16 PM

• jon added inline comments.

services/blob/src/http/mod.rs
21 ↗	(On Diff #25936)	not directly related to this diff, but I would like to move away from `--sandbox`, and instead just see if the binary is in debug mode. #[cfg(debug_assertions)] fn is_sandbox() { return true; } Also gets rid of a bunch of branching logic