This differential populates keyserver_olm_account table with primary and notifications olm accounts. Methods to create pickled olm account and unpickle pickled olm account are implemented as well. Pickled olm account creation implementation is take from the following diff:
https://phab.comm.dev/D3209. It might be usefull for reviewers to take a look at this diff to potentially avoid questions that have already been answered.
Details
Details
Repeat test plan for the parent diff. Additionally using database inspection tool of choice examine the content of keyserver_olm_accounts table. Ensure there are two different accounts there that one of which has is_primary set to TRUE, while the other set to FASLE.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Please address my feedback before landing... repeating it from last review
| keyserver/src/database/migration-config.js | ||
|---|---|---|
| 378–379 ↗ | (On Diff #25592) | Lines are still too long. Please keep lines to a max of 80 chars |
| keyserver/src/database/setup-db.js | ||
| 461–464 ↗ | (On Diff #25592) | Once again, please keep all lines to a max of 80 chars |
Comment Actions
Please address line length issues before your next update!! This is my third time repeating this on this diff!!