Differential D7824

[web] Enter edit state after pressing edit button
AbandonedPublic
Actions

Authored by • kuba on May 16 2023, 1:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Mar 15, 5:23 PM

	Unknown Object (File)
	Tue, Mar 11, 4:03 PM

	Unknown Object (File)
	Thu, Mar 6, 12:24 PM

	Unknown Object (File)
	Tue, Mar 4, 8:22 AM

	Unknown Object (File)
	Tue, Mar 4, 8:22 AM

	Unknown Object (File)
	Tue, Mar 4, 8:21 AM

	Unknown Object (File)
	Tue, Mar 4, 8:15 AM

	Unknown Object (File)
	Feb 27 2025, 7:50 AM

Subscribers

Details

Reviewers

michal
inka

Summary

Set the edited message after pressing the edit button.

Test Plan

Run the app. Checked in the dev tools if the state is changed after pressing the edit button.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• kuba created this revision.May 16 2023, 1:54 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 16 2023, 1:54 AM

• kuba added a parent revision: D7823: [web] Added EditTextMessage component.May 16 2023, 1:54 AM

• kuba edited the summary of this revision. (Show Details)

• kuba edited the test plan for this revision. (Show Details)

• kuba added a child revision: D7825: [web] Store edited message draft in the state.May 16 2023, 1:57 AM

Harbormaster completed remote builds in B19359: Diff 26490.May 16 2023, 2:12 AM

• kuba requested review of this revision.May 16 2023, 2:12 AM

michal mentioned this in D7793: [web] Added edit button to the Tooltip.May 16 2023, 11:05 AM

Clearing tooltip after entering edit mode

Harbormaster completed remote builds in B19441: Diff 26591.May 17 2023, 4:08 AM

• kuba abandoned this revision.May 17 2023, 6:44 AM

Revision Contents
Changeset List

Path

Size

web/

utils/

tooltip-action-utils.js

15 lines

Diff 26490

web/utils/tooltip-action-utils.js

	#include "ClientGetReadReactor.h"			#include <grpc/ClientGetReadReactor.h>

	ClientGetReadReactor::ClientGetReadReactor(			ClientGetReadReactor::ClientGetReadReactor(
	tunnelbroker::TunnelbrokerService::Stub *stub,			tunnelbroker::TunnelbrokerService::Stub *stub,
	std::string sessionID)			std::string sessionID)
	: sessionID{sessionID}, request{} {			: sessionID{sessionID}, request{} {
	request.set_sessionid(sessionID);			request.set_sessionid(sessionID);
	stub->async()->Get(&(this->context), &(this->request), this);			stub->async()->Get(&(this->context), &(this->request), this);
	StartRead(&(this->response));			StartRead(&(this->response));
	▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines