Paths

Table of Contentst

Differential D8013

[web] Use search users in chat composer
ClosedPublic
Actions

Authored by michal on May 29 2023, 7:00 AM.

Tags

None

Referenced Files

	F3391199: D8013.diff
	Sat, Nov 30, 2:43 AM

	Unknown Object (File)
	Oct 26 2024, 11:43 PM

	Unknown Object (File)
	Oct 26 2024, 11:43 PM

	Unknown Object (File)
	Oct 26 2024, 11:43 PM

	Unknown Object (File)
	Oct 26 2024, 11:35 PM

	Unknown Object (File)
	Oct 26 2024, 2:23 PM

	Unknown Object (File)
	Oct 3 2024, 12:51 AM

	Unknown Object (File)
	Oct 3 2024, 12:51 AM

View All 76 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMMc28f64bd7632: [web] Use search users in chat composer

Summary

We want to use search users in chat composer so can create chat with users not in user store

Depends on D8012

Test Plan

Search for users. Check if there are users not in user store. Check if they can be selected properly

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.May 29 2023, 7:00 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 7:00 AM

Harbormaster completed remote builds in B19828: Diff 27159.May 29 2023, 7:18 AM

michal requested review of this revision.May 29 2023, 7:18 AM

kamil requested changes to this revision.May 30 2023, 9:42 AM

kamil added inline comments.

web/chat/chat-thread-composer.react.js
65–87	I think there is a possibility to wrap this in a hook in `lib` to avoid code duplication with D8010? Or am I missing something? Or at least you can move shared code to a shared function
71–80	Are you sure that debounce is not needed?

This revision now requires changes to proceed.May 30 2023, 9:42 AM

kamil mentioned this in D8010: [native] Use search users in chat composer.May 30 2023, 9:45 AM

michal added a parent revision: D8010: [native] Use search users in chat composer.Jun 2 2023, 5:32 AM

Removed code duplication (function was introduced in D8010)

web/chat/chat-thread-composer.react.js
71–80	Other places are not yet debounced, a task for this already exists: https://linear.app/comm/issue/ENG-1327.

Harbormaster completed remote builds in B19984: Diff 27395.Jun 2 2023, 5:57 AM

kamil accepted this revision.Jun 5 2023, 2:09 AM

This revision is now accepted and ready to land.Jun 5 2023, 2:09 AM

• kuba mentioned this in D5463: [web] Call searchUsers in chat composer.Jun 14 2023, 12:54 AM

Closed by commit rCOMMc28f64bd7632: [web] Use search users in chat composer (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJun 14 2023, 6:32 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMc28f64bd7632: [web] Use search users in chat composer.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-thread-composer.react.js

52 lines

Diff 27159

web/chat/chat-thread-composer.react.js

Loading...