Page MenuHomePhabricator

[landing] introduce competitor feature base component
ClosedPublic

Authored by ginsu on May 29 2023, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 18, 12:57 PM
Unknown Object (File)
Mon, May 13, 2:02 AM
Unknown Object (File)
Fri, May 10, 2:45 AM
Unknown Object (File)
Fri, May 10, 2:27 AM
Unknown Object (File)
Sun, May 5, 8:15 AM
Unknown Object (File)
Sat, May 4, 4:04 PM
Unknown Object (File)
Apr 11 2024, 9:52 AM
Unknown Object (File)
Apr 11 2024, 9:52 AM
Subscribers

Details

Summary

The competitor comparison cards and competitor comparison modal will have a similar structure so I factored out the base component so that both places can use this code. A subsequent diff will handle the introduction of the competitor comparison modal. This diff is mainly a move diff

Depends on D7905

Test Plan

The competitor feature cards look and behave the same, and I will do more testing of the competitor comparison modal when I introduce it

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu requested review of this revision.May 29 2023, 7:56 PM
This revision is now accepted and ready to land.May 30 2023, 7:23 AM