Page MenuHomePhabricator
Differential D8012

[keyserver] Include initial navInfo selectedUserList
ClosedPublic
Actions

Authored by michal on May 29 2023, 6:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 10:01 PM
Unknown Object (File)
Thu, Nov 7, 10:58 AM
Unknown Object (File)
Thu, Nov 7, 1:53 AM
Unknown Object (File)
Wed, Oct 30, 3:25 PM
Unknown Object (File)
Wed, Oct 30, 3:25 PM
Unknown Object (File)
Wed, Oct 30, 3:24 PM
Unknown Object (File)
Wed, Oct 30, 3:24 PM
Unknown Object (File)
Wed, Oct 30, 3:22 PM
View All 86 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
kamil
inka
ashoat
Commits
rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList
Summary

If you navigate directly to an url for chat creation we want to include the mentioned users infos in the nav info.

Depends on D8011

Test Plan

Navigate to /chat/create/<user-not-in-userstore> and /chat/create/<user-in-userstore> and check if they both work correctly

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.May 29 2023, 6:59 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 6:59 AM
michal added a child revision: D8013: [web] Use search users in chat composer.May 29 2023, 7:00 AM
Harbormaster completed remote builds in B19827: Diff 27158.May 29 2023, 7:16 AM
michal requested review of this revision.May 29 2023, 7:16 AM
ashoat accepted this revision.May 29 2023, 7:43 AM
ashoat added inline comments.
keyserver/src/responders/website-responders.js
270 ↗(On Diff #27158)

Can you add a code comment explaining what you're doing here?

313–316 ↗(On Diff #27158)

Why are these being awaited in sequence?

web/url-utils.js
83–85 ↗(On Diff #27158)

Can we update this to be read-only?

This revision is now accepted and ready to land.May 29 2023, 7:43 AM
ashoat added inline comments.May 29 2023, 7:43 AM
keyserver/src/responders/website-responders.js
313–316 ↗(On Diff #27158)

Sorry, ignore this comment

michal updated this revision to Diff 27394.Jun 2 2023, 5:38 AM

Comment and readonly

Harbormaster completed remote builds in B19983: Diff 27394.Jun 2 2023, 5:54 AM
Closed by commit rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJun 14 2023, 6:32 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM1617e44dbb87: [keyserver] Include initial navInfo selectedUserList.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
2 lines
responders/
82 lines
web/
4 lines
15 lines

Diff 27394

View Options

keyserver/src/fetchers/user-fetchers.js

Loading...
View Options

keyserver/src/responders/website-responders.js

Loading...
View Options

web/app.react.js

Loading...
View Options

web/url-utils.js

Loading...