Page MenuHomePhabricator
Differential D8032

[landing] introduce slack competitor data
ClosedPublic
Actions

Authored by ginsu on May 30 2023, 9:07 AM.
Tags
None
Referenced Files
F3372136: D8032.diff
Tue, Nov 26, 5:42 AM
Unknown Object (File)
Sun, Nov 17, 2:19 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
Unknown Object (File)
Sun, Nov 17, 1:36 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM3e2bda1aa259: [landing] introduce slack competitor data
Summary

introduce slack competitor data. The copy was copied and pasted from this linear task.

Depends on D8030

Test Plan

Please see screenshots below:

Screenshot 2023-08-06 at 3.37.20 PM.png (2×3 px, 915 KB)

Screenshot 2023-08-06 at 3.37.25 PM.png (2×3 px, 874 KB)

Screenshot 2023-08-06 at 3.37.35 PM.png (2×3 px, 1000 KB)

Screenshot 2023-08-06 at 3.37.30 PM.png (2×3 px, 1009 KB)

Screenshot 2023-08-06 at 3.37.51 PM.png (2×3 px, 968 KB)

Screenshot 2023-08-06 at 3.37.32 PM.png (2×3 px, 968 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.May 30 2023, 9:07 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 30 2023, 9:07 AM
ginsu edited the summary of this revision. (Show Details)May 30 2023, 9:08 AM
ginsu added a parent revision: D8030: [landing] introduce Matrix competitor data.
ginsu added a child revision: D8033: [landing] introduce telegram competitor data.May 30 2023, 9:11 AM
Harbormaster completed remote builds in B19907: Diff 27269.May 30 2023, 9:25 AM
ginsu requested review of this revision.May 30 2023, 9:25 AM
ginsu updated this revision to Diff 27275.May 30 2023, 11:35 AM

add key

Harbormaster failed remote builds in B19913: Diff 27275!May 30 2023, 12:12 PM
ginsu updated this revision to Diff 28795.Jul 18 2023, 2:09 PM

change long description type from string to $ReadOnlyArray<string>. D8537 introduces logic to the CompetitorFeature so that it can handle multiple paragraphs in the long descriptions.

Harbormaster completed remote builds in B21005: Diff 28795.Jul 18 2023, 2:39 PM
ginsu updated this revision to Diff 29571.Aug 6 2023, 1:39 PM

update copy

ginsu edited the summary of this revision. (Show Details)Aug 6 2023, 1:43 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil.
ginsu attached a referenced file: F677146: Screenshot 2023-08-06 at 3.37.32 PM.png. (Show Details)
ginsu attached a referenced file: F677147: Screenshot 2023-08-06 at 3.37.51 PM.png. (Show Details)
ginsu attached a referenced file: F677148: Screenshot 2023-08-06 at 3.37.30 PM.png. (Show Details)
ginsu attached a referenced file: F677149: Screenshot 2023-08-06 at 3.37.35 PM.png. (Show Details)
ginsu attached a referenced file: F677145: Screenshot 2023-08-06 at 3.37.25 PM.png. (Show Details)
ginsu attached a referenced file: F677144: Screenshot 2023-08-06 at 3.37.20 PM.png. (Show Details)
ginsu retitled this revision from DRAFT [landing] introduce slack competitor data to [landing] introduce slack competitor data.
Harbormaster completed remote builds in B21555: Diff 29571.Aug 6 2023, 1:57 PM
atul accepted this revision.Aug 7 2023, 10:29 PM
This revision is now accepted and ready to land.Aug 7 2023, 10:29 PM
ginsu updated this revision to Diff 29670.Aug 8 2023, 12:21 PM

rebase before landing

Harbormaster completed remote builds in B21624: Diff 29670.Aug 8 2023, 1:25 PM
Closed by commit rCOMM3e2bda1aa259: [landing] introduce slack competitor data (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3e2bda1aa259: [landing] introduce slack competitor data.

Revision Contents
Changeset List

PathSize
landing/
82 lines

Diff 28795

View Options

landing/competitor-data.js

Loading...