Page MenuHomePhabricator
Differential D8547

[web] add function to retrieve WASM module
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 2:56 AM.
Tags
None
Referenced Files
F3176716: D8547.diff
Thu, Nov 7, 9:32 PM
F3176426: D8547.diff
Thu, Nov 7, 9:21 PM
Unknown Object (File)
Fri, Nov 1, 3:55 PM
Unknown Object (File)
Fri, Nov 1, 3:32 PM
Unknown Object (File)
Sat, Oct 26, 1:59 AM
Unknown Object (File)
Tue, Oct 15, 2:05 AM
Unknown Object (File)
Sun, Oct 13, 3:14 AM
Unknown Object (File)
Sep 28 2024, 1:54 AM
View All 100 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM7a6f37fbccf9: [web] add function to retrieve WASM module
Summary

Making sure that module is now typed in Flow, and making it easier to retrieve the module (will be helpful in tests later).

Depends on D8545

Test Plan
  1. flow
  2. Check if result is still logged

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 19 2023, 2:56 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 2:56 AM
kamil added inline comments.Jul 19 2023, 2:59 AM
web/database/db-module.js
7 ↗(On Diff #28818)

In general I wanted one function which will work for prod/dev/tests

web/database/worker/db-worker.js
69 ↗(On Diff #28818)

sqljsFilePath will be renamed later in the stack

Harbormaster completed remote builds in B21023: Diff 28818.Jul 19 2023, 3:15 AM
kamil added a child revision: D8553: [web] add SQLiteQueryExecutor bindings and type.Jul 19 2023, 6:49 AM
kamil published this revision for review.Jul 19 2023, 8:58 AM
michal accepted this revision.Jul 20 2023, 7:40 AM
This revision is now accepted and ready to land.Jul 20 2023, 7:40 AM
Closed by commit rCOMM7a6f37fbccf9: [web] add function to retrieve WASM module (authored by kamil). · Explain WhyJul 21 2023, 7:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM7a6f37fbccf9: [web] add function to retrieve WASM module.

Revision Contents
Changeset List

PathSize
web/
database/
25 lines
utils/
2 lines
worker/
13 lines

Diff 28934

View Options

web/database/db-module.js

Loading...
View Options

web/database/utils/constants.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...