Page MenuHomePhabricator
Differential D8560

[web] switch code from `sql.js` API to `.wasm` database module
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 7:05 AM.
Tags
None
Referenced Files
F3174872: D8560.id29134.diff
Thu, Nov 7, 6:39 PM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:07 AM
Unknown Object (File)
Tue, Nov 5, 7:04 AM
Unknown Object (File)
Mon, Nov 4, 8:59 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMMc0d08c769365: [web] switch code from `sql.js` API to `.wasm` database module
Summary

This is very important diff - it starts using .wasm API from SQLiteQueryExecutor instead of sql.js.

We do not have to migrate this content, we will simply take old content from indexedDB and put this to database module (schema is the same).

Depends on D8559

Test Plan

Test everything end-to-end.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 7:05 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 7:05 AM
kamil added a child revision: D8561: [web] remove old raw SQL queries.Jul 19 2023, 7:06 AM
Harbormaster completed remote builds in B21039: Diff 28835.Jul 19 2023, 7:59 AM
kamil published this revision for review.Jul 19 2023, 9:11 AM
michal added a comment.EditedJul 24 2023, 1:09 AM

How does this interact with migrations?

EDIT: I talked with @kamil and the native migrations will just run and bump the db version to match the native. But it's fine because the schema between web and native is the same

web/database/worker/db-worker.js
234 ↗(On Diff #28835)

Is this needed?

michal accepted this revision.Jul 24 2023, 5:35 AM
This revision is now accepted and ready to land.Jul 24 2023, 5:35 AM
kamil updated this revision to Diff 29006.Jul 25 2023, 2:11 AM

rebase

kamil added inline comments.Jul 25 2023, 2:13 AM
web/database/worker/db-worker.js
234 ↗(On Diff #28835)

it is not, good catch

kamil edited parent revisions, added: D8557: [web] rework storage engine tests to use CommQueryExecutor; removed: D8559: [web] implement functions to import/export database content.Jul 25 2023, 2:14 AM
kamil added a child revision: D8612: [web] handle clearing sensitive data on database module.
kamil removed a child revision: D8561: [web] remove old raw SQL queries.
Harbormaster failed remote builds in B21173: Diff 29006!Jul 25 2023, 3:14 AM
kamil updated this revision to Diff 29133.Jul 27 2023, 7:18 AM
kamil added a parent revision: D8559: [web] implement functions to import/export database content.

CI

kamil removed a parent revision: D8559: [web] implement functions to import/export database content.Jul 27 2023, 7:22 AM
Harbormaster completed remote builds in B21275: Diff 29133.Jul 27 2023, 7:37 AM
Closed by commit rCOMMc0d08c769365: [web] switch code from `sql.js` API to `.wasm` database module (authored by kamil). · Explain WhyJul 27 2023, 7:38 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc0d08c769365: [web] switch code from `sql.js` API to `.wasm` database module.
kamil mentioned this in D8562: [keyserver] stop hosting `sql.js` binary file.Jul 28 2023, 3:32 AM

Revision Contents
Changeset List

PathSize
web/
database/
utils/
2 lines
worker/
93 lines

Diff 29006

View Options

web/database/utils/constants.js

Loading...
View Options

web/database/worker/db-worker.js

Loading...