Page MenuHomePhabricator
Differential D8015

[landing] introduce competitor logo component
ClosedPublic
Actions

Authored by ginsu on May 29 2023, 2:46 PM.
Tags
None
Referenced Files
F3883689: D8015.id27230.diff
Thu, Jan 23, 11:10 PM
F3883153: D8015.id29731.diff
Thu, Jan 23, 10:39 PM
F3881402: D8015.diff
Thu, Jan 23, 9:19 PM
F3879901: D8015.id29731.diff
Thu, Jan 23, 7:45 PM
F3879888: D8015.id27230.diff
Thu, Jan 23, 7:31 PM
Unknown Object (File)
Mon, Jan 20, 6:58 PM
Unknown Object (File)
Sun, Jan 5, 5:41 AM
Unknown Object (File)
Sun, Jan 5, 5:41 AM
View All 89 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM3c6fb301b6c5: [landing] introduce competitor logo component
Summary

Based on feedback in D7905 I created a lightweight wrapper component for all the competitor logos. I will update D7905 to use the new component.

Depends on D7945

Test Plan

Logos still rendered

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.May 29 2023, 2:46 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 29 2023, 2:46 PM
ginsu edited the summary of this revision. (Show Details)May 29 2023, 2:46 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D7904: [landing] introduce signal competitor data.
ginsu edited the summary of this revision. (Show Details)
ginsu added a child revision: D7905: [landing] introduce competitor feature card component.
ginsu mentioned this in D7905: [landing] introduce competitor feature card component.May 29 2023, 2:49 PM
Harbormaster completed remote builds in B19874: Diff 27230.May 29 2023, 3:05 PM
ginsu requested review of this revision.May 29 2023, 3:05 PM
ginsu edited the summary of this revision. (Show Details)May 29 2023, 4:35 PM
ginsu added a parent revision: D7945: [landing] add size prop to logo components.
ginsu removed a parent revision: D7904: [landing] introduce signal competitor data.
ginsu added a child revision: D7904: [landing] introduce signal competitor data.
ginsu removed a child revision: D7905: [landing] introduce competitor feature card component.May 29 2023, 4:38 PM
atul accepted this revision.May 30 2023, 7:16 AM
This revision is now accepted and ready to land.May 30 2023, 7:16 AM
ginsu updated this revision to Diff 29653.Aug 8 2023, 12:12 PM

rebase before landing

Harbormaster completed remote builds in B21613: Diff 29653.Aug 8 2023, 12:52 PM
Closed by commit rCOMM3c6fb301b6c5: [landing] introduce competitor logo component (authored by ginsu). · Explain WhyAug 8 2023, 2:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM3c6fb301b6c5: [landing] introduce competitor logo component.

Revision Contents
Changeset List

PathSize
landing/
38 lines

Diff 29731

View Options

landing/competitor-logo.react.js

Loading...