Page MenuHomePhabricator
Differential D8962

[backup] Update `BlobItem`
ClosedPublic
Actions

Authored by michal on Aug 28 2023, 12:57 AM.
Tags
None
Referenced Files
F3346425: D8962.diff
Fri, Nov 22, 8:45 AM
Unknown Object (File)
Tue, Nov 19, 7:52 AM
Unknown Object (File)
Mon, Nov 18, 12:27 PM
Unknown Object (File)
Mon, Nov 18, 12:20 PM
Unknown Object (File)
Fri, Nov 8, 11:06 AM
Unknown Object (File)
Sun, Oct 27, 5:01 PM
Unknown Object (File)
Sep 28 2024, 4:48 PM
Unknown Object (File)
Sep 27 2024, 11:58 PM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
• patryk
kamil
• jon
Commits
rCOMM3c1ce0afaf0f: [backup] Update `BlobItem`
Summary

Modernize BlobItem and update it to match new database design.

Depends on D8954

Test Plan

cargo check, tested with the rest of the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

michal created this revision.Aug 28 2023, 12:57 AM
Herald added a reviewer: • jon. · View Herald TranscriptAug 28 2023, 12:57 AM
Herald added subscribers: tomek, ashoat. · View Herald Transcript
Harbormaster completed remote builds in B22154: Diff 30419.Aug 28 2023, 1:14 AM
michal requested review of this revision.Aug 28 2023, 1:14 AM
michal added a child revision: D8963: [backup] Introduce upload endpoint.Aug 28 2023, 1:33 AM
bartek accepted this revision.Aug 28 2023, 5:00 AM
bartek added inline comments.
services/backup/src/constants.rs
17–24

Nit/followup: You're right that it would be nice to add a submodule for table constants: constants::backup_table::FIELD_XYZ

This revision is now accepted and ready to land.Aug 28 2023, 5:00 AM
michal added inline comments.Aug 29 2023, 10:55 AM
services/backup/src/constants.rs
17–24

Probably gonna do a separate diff with both backup and log constants

Closed by commit rCOMM3c1ce0afaf0f: [backup] Update `BlobItem` (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyAug 30 2023, 1:28 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM3c1ce0afaf0f: [backup] Update `BlobItem`.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
4 lines
database/
147 lines
37 lines
comm-services-lib/
src/
22 lines

Diff 30419

View Options

services/backup/src/constants.rs

Loading...
View Options

services/backup/src/database/backup_item.rs

Loading...
View Options

services/backup/src/database/mod.rs

Loading...
View Options

services/comm-services-lib/src/database.rs

Loading...