[native] get signed prekeys
ClosedPublic
Actions

Authored by varun on Sep 5 2023, 7:02 AM.

Details

Reviewers

marcin
atul

Commits

rCOMM58a033c26d1b: [native] get signed prekeys

Summary

modify the existing generateAndGetPrekey function to return signed content and notif prekeys (prekey + signature)

Test Plan

console logged generateAndGetPrekeys from account-selectors.js and got the following:

LOG  {"contentPrekey": "{\"curve25519\":{\"AAAAAg\":\"9QT6LlKsgI+badfNPLMhlWon5GZjCBjFVTur/W/qRkY\"}}", "contentPrekeySignature": "T64w13LqXgw0M7F6d19qL5pQyfE+c86CdgNlckIPIQwiI+INDttUjxSNVaa9Vv0AMIqNC+2tq2NvzqTTPESCAg", "notifPrekey": "{\"curve25519\":{\"AAAAAg\":\"9cN8Gem9icUP869ydpukc9LkGXFj89ZZ1JT5IPma234\"}}", "notifPrekeySignature": "+CjQcbt4qKAMp2zQlAzg+zpJZ++OsLUjeMh9NuJVVoPNhPt7DEpPa1WEsYmH3hCEd8QqSxQM4lqH1mVvr3O3BA"}

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Sep 5 2023, 7:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 7:02 AM

varun added a parent revision: D9083: [native] generateAndGetNotificationsPrekey.Sep 5 2023, 7:03 AM

Harbormaster completed remote builds in B22388: Diff 30764.Sep 5 2023, 7:21 AM

varun requested review of this revision.Sep 5 2023, 7:21 AM

varun added a child revision: D9085: [native] getNotificationsOneTimeKeys.Sep 5 2023, 7:32 AM

marcin added inline comments.Sep 6 2023, 1:45 AM

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
570–578 ↗	(On Diff #30764)	Is it possible to sign the entire prekey JSON: { "contentPrekey": ."..", "notifPrekey": .".." } instead of signing both keys separately? When it comes to public keys we sign the entire payload of `curve25519` and `ed25519` for both content and notifs at once. What is the reason behind signing prekeys separately?

Would be good for @marcin or @bartek to take a closer look here

should be using olm_account_prekey_signature()

introduce new CryptoModule function to get signed prekey the correct way

Harbormaster completed remote builds in B22454: Diff 30871.Sep 8 2023, 9:08 AM

marcin accepted this revision.Sep 11 2023, 5:12 AM

marcin added inline comments.

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
542–543	I think those two should also but inside `try{}catch{}` since they might also fails as they are using the same methods of `CryptoModule` class under the hood. We are not doing so in other places but we probably should be.