[native] generateAndGetNotificationsPrekey
ClosedPublic
Actions

Authored by varun on Sep 5 2023, 6:07 AM.

Details

Reviewers

marcin
atul

Commits

rCOMMf1cc65ed1a2e: [native] generateAndGetNotificationsPrekey

Summary

We'll need to send the notif prekey/prekey signature to identity service. Exposing a function that lets us generate and get a notif prekey.

Depends on D9076

Test Plan

tested in subsequent diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Sep 5 2023, 6:07 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 5 2023, 6:07 AM

Harbormaster completed remote builds in B22387: Diff 30763.Sep 5 2023, 6:24 AM

varun requested review of this revision.Sep 5 2023, 6:24 AM

varun added a child revision: D9084: [native] get signed prekeys.Sep 5 2023, 7:03 AM

marcin accepted this revision.Sep 6 2023, 1:39 AM

atul resigned from this revision.Sep 6 2023, 2:04 PM

atul added a subscriber: bartek.

atul added inline comments.

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.cpp
198–201 ↗	(On Diff #30763)	Don't really understand this, would be good for @marcin or @bartek to take a close look

This revision is now accepted and ready to land.Sep 6 2023, 2:04 PM

Closed by commit rCOMMf1cc65ed1a2e: [native] generateAndGetNotificationsPrekey (authored by varun). · Explain WhySep 12 2023, 12:54 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMf1cc65ed1a2e: [native] generateAndGetNotificationsPrekey.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

Notifications/

BackgroundDataStorage/

NotificationsCryptoModule.h

2 lines

NotificationsCryptoModule.cpp

10 lines

Diff 30981

View Options

native/cpp/CommonCpp/Notifications/BackgroundDataStorage/NotificationsCryptoModule.h