[native] update UserProfileBottomSheet to get a userInfo from a userID
ClosedPublic
Actions

Authored by ginsu on Sep 10 2023, 11:08 PM.

Details

Reviewers

atul
inka

Commits

rCOMM10935364caf9: [native] update UserProfileBottomSheet to get a userInfo from a userID

Summary

As a follow up to D9119 we can now update the userInfo in UserProfileBottomSheetParams to be a userID and use that to grab the userInfo using a selector. Another benefit of doing this is that this also makes navigating to UserProfileBottomSheet a lot more permissive since we only need to pass a userID (something similar to what we did with user avatars)

Depends on D9119

Test Plan

Please see the demo video below where I can view the user profile from the thread settings (uses a RelativeMemberInfo) and RelationshipList (which uses AccountUserInfo)

Also tested the case when we can't find user with an id not found in our store by hardcoding null for userInfo

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 10 2023, 11:08 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 10 2023, 11:08 PM

ginsu edited the summary of this revision. (Show Details)Sep 10 2023, 11:12 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9119: [native] use stringForUserExplicit function to determine username text for profiles.

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F752021: Screen Recording 2023-09-11 at 2.13.06 AM.mov. (Show Details)

ginsu attached a referenced file: F752020: Screen Recording 2023-09-11 at 2.12.14 AM.mov. (Show Details)

Harbormaster completed remote builds in B22479: Diff 30910.Sep 10 2023, 11:27 PM

ginsu requested review of this revision.Sep 10 2023, 11:27 PM

Is it possible that a user with this id will not be in our store?

ashoat added inline comments.Sep 12 2023, 11:51 AM

native/bottom-sheets/user-profile-bottom-sheet.react.js
30 ↗	(On Diff #30910)	This should be typed as optional for the reason @inka identified

Sending back to your queue to address feedback from @inka/@ashoat

This revision now requires changes to proceed.Sep 12 2023, 1:33 PM

In D9120#269321, @inka wrote:

Is it possible that a user with this id will not be in our store?

Overall, we should be really cautious when accessing arrays in Flow https://flow.org/en/docs/types/arrays/#toc-array-access-is-unsafe.

address feedback

ginsu edited the test plan for this revision. (Show Details)Sep 14 2023, 10:03 AM

ginsu attached a referenced file: F759554: Screen Recording 2023-09-14 at 1.00.25 PM.mov. (Show Details)

ginsu added inline comments.Sep 14 2023, 10:05 AM

lib/shared/user-utils.js
13	Not using this function but figured it would be good to make this function more permissive too since `stringForUserExplicit` now makes the `user` argument optional