Page MenuHomePhabricator
Differential D9272

[native] introduce BottomSheetProvider
ClosedPublic
Actions

Authored by ginsu on Sep 24 2023, 11:29 PM.
Tags
None
Referenced Files
F3360529: D9272.diff
Sun, Nov 24, 1:08 PM
Unknown Object (File)
Thu, Nov 21, 10:55 PM
Unknown Object (File)
Thu, Nov 21, 10:43 PM
Unknown Object (File)
Thu, Nov 21, 10:28 PM
Unknown Object (File)
Thu, Nov 21, 10:20 PM
Unknown Object (File)
Thu, Nov 21, 12:32 AM
Unknown Object (File)
Fri, Nov 1, 12:48 PM
Unknown Object (File)
Oct 26 2024, 1:27 AM
View All 95 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMb272611288b5: [native] introduce BottomSheetProvider
Summary

To make the snap point of the bottom sheet dynamic and based off the height of the content shown on the bottom sheet, we need to measure and keep track of the height of the bottom sheet content. This diff introduces a BottomSheet provider with a single piece of state (at least for now) to keep track of this height of the bottom sheet content across multiple different components

Depends on D9271

Test Plan

flow and confirmed that I was able to grab the context values in the bottom sheet related components

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Sep 24 2023, 11:29 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 24 2023, 11:29 PM
ginsu edited the summary of this revision. (Show Details)Sep 24 2023, 11:33 PM
ginsu added reviewers: atul, inka.
ginsu added inline comments.Sep 24 2023, 11:36 PM
native/bottom-sheet/bottom-sheet-provider.react.js
21

We need to use 1 here otherwise we get the following error from the bottom sheet library:

Screenshot 2023-09-25 at 2.35.25 AM.png (1×1 px, 825 KB)

ginsu added a child revision: D9273: [native] factor out UserProfileRelationshipButton condtionals.Sep 24 2023, 11:39 PM
Harbormaster completed remote builds in B22811: Diff 31381.Sep 24 2023, 11:47 PM
ginsu requested review of this revision.Sep 24 2023, 11:47 PM
ginsu edited the summary of this revision. (Show Details)Sep 24 2023, 11:57 PM
ginsu added a parent revision: D9271: [native] improve organization of user profiles work.
ginsu attached a referenced file: F772625: Screenshot 2023-09-25 at 2.35.25 AM.png. (Show Details)
atul accepted this revision.Sep 26 2023, 1:36 PM

Seems reasonable

This revision is now accepted and ready to land.Sep 26 2023, 1:36 PM
ginsu updated this revision to Diff 31533.Sep 28 2023, 10:17 AM
ginsu edited the summary of this revision. (Show Details)

fix merge conflict after merging master

Harbormaster completed remote builds in B22901: Diff 31533.Sep 28 2023, 10:35 AM
ginsu updated this revision to Diff 31566.Sep 29 2023, 12:33 PM

rebase before landing

Harbormaster completed remote builds in B22928: Diff 31566.Sep 29 2023, 12:50 PM
Closed by commit rCOMMb272611288b5: [native] introduce BottomSheetProvider (authored by ginsu). · Explain WhySep 29 2023, 1:27 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb272611288b5: [native] introduce BottomSheetProvider.

Revision Contents
Changeset List

PathSize
native/
bottom-sheet/
38 lines
37 lines

Diff 31381

View Options

native/bottom-sheet/bottom-sheet-provider.react.js

Loading...
View Options

native/root.react.js

Loading...