Page MenuHomePhabricator

[native] introduce BottomSheetProvider
ClosedPublic

Authored by ginsu on Sep 24 2023, 11:29 PM.
Tags
None
Referenced Files
F3332627: D9272.id31533.diff
Thu, Nov 21, 12:32 AM
Unknown Object (File)
Fri, Nov 1, 12:48 PM
Unknown Object (File)
Sat, Oct 26, 1:27 AM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:41 PM
Unknown Object (File)
Oct 20 2024, 3:40 PM
Subscribers

Details

Summary

To make the snap point of the bottom sheet dynamic and based off the height of the content shown on the bottom sheet, we need to measure and keep track of the height of the bottom sheet content. This diff introduces a BottomSheet provider with a single piece of state (at least for now) to keep track of this height of the bottom sheet content across multiple different components

Depends on D9271

Test Plan

flow and confirmed that I was able to grab the context values in the bottom sheet related components

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added reviewers: atul, inka.
native/bottom-sheet/bottom-sheet-provider.react.js
21 ↗(On Diff #31381)

We need to use 1 here otherwise we get the following error from the bottom sheet library:

Screenshot 2023-09-25 at 2.35.25 AM.png (1×1 px, 825 KB)

This revision is now accepted and ready to land.Sep 26 2023, 1:36 PM
ginsu edited the summary of this revision. (Show Details)

fix merge conflict after merging master

This revision was automatically updated to reflect the committed changes.