Paths

Table of Contentst

Differential D9271

[native] improve organization of user profiles work
ClosedPublic
Actions

Authored by ginsu on Sep 22 2023, 2:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 1, 12:46 AM

	Unknown Object (File)
	Sat, Feb 1, 12:46 AM

	Unknown Object (File)
	Sat, Feb 1, 12:46 AM

	Unknown Object (File)
	Sat, Feb 1, 12:46 AM

	Unknown Object (File)
	Sat, Feb 1, 12:41 AM

	Unknown Object (File)
	Thu, Jan 30, 8:13 PM

	Unknown Object (File)
	Sat, Jan 25, 2:46 AM

	Unknown Object (File)
	Sat, Jan 25, 2:21 AM

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM588581374141: [native] improve organization of user profiles work

Summary

Working on user profiles, I was introducing/will be continueing to introduce more files for user profiles. To better organize this, I think we should have a dedicated folder called user-profile to house all of the user profile files/code so we can keep everything in once place.

I also renamed the bottom-sheets directory => bottom-sheet

Depends on D9260

Test Plan

flow

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 22 2023, 2:03 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 22 2023, 2:03 PM

ginsu edited the summary of this revision. (Show Details)Sep 22 2023, 2:03 PM

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9260: [native] improve BottomSheet component close function.

ginsu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B22810: Diff 31380.Sep 22 2023, 2:22 PM

ginsu requested review of this revision.Sep 22 2023, 2:22 PM

ginsu added a child revision: D9272: [native] introduce BottomSheetProvider.Sep 24 2023, 11:57 PM

Just skimmed through, trusting CI here

This revision is now accepted and ready to land.Sep 26 2023, 1:28 PM

rebase before landing

Harbormaster completed remote builds in B22921: Diff 31555.Sep 29 2023, 12:06 PM

Closed by commit rCOMM588581374141: [native] improve organization of user profiles work (authored by ginsu). · Explain WhySep 29 2023, 12:10 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM588581374141: [native] improve organization of user profiles work.

Revision Contents
Changeset List

Path

Size

native/

	bottom-sheet/
	bottom-sheets/

bottom-sheet-backdrop.react.js

bottom-sheet-handle.react.js

bottom-sheet.react.js

bottom-sheets/

bottom-sheet-backdrop.react.js

bottom-sheet-handle.react.js

bottom-sheet.react.js

user-profile-bottom-sheet.react.js

components/

user-profile-message-button.react.js

user-profile-relationship-button.react.js

user-profile.react.js

navigation/

root-navigator.react.js

2 lines

2 lines

	user-profile/
	bottom-sheets/

user-profile-bottom-sheet.react.js

4 lines

	user-profile/
	components/

user-profile-message-button.react.js

4 lines

user-profile-relationship-button.react.js

2 lines

user-profile.react.js

2 lines

Diff 31563

native/bottom-sheet/bottom-sheet-backdrop.react.js

Loading...

native/bottom-sheet/bottom-sheet-handle.react.js

Loading...

native/bottom-sheet/bottom-sheet.react.js

Loading...

native/bottom-sheets/bottom-sheet-backdrop.react.js

Loading...

native/bottom-sheets/bottom-sheet-handle.react.js

Loading...

native/bottom-sheets/bottom-sheet.react.js

Loading...

native/bottom-sheets/user-profile-bottom-sheet.react.js

Loading...

native/components/user-profile-message-button.react.js

Loading...

native/components/user-profile-relationship-button.react.js

Loading...

native/components/user-profile.react.js

Loading...

native/navigation/root-navigator.react.js

Loading...

native/navigation/route-names.js

Loading...

native/user-profile/user-profile-bottom-sheet.react.js

Loading...

native/user-profile/user-profile-message-button.react.js

Loading...

native/user-profile/user-profile-relationship-button.react.js

Loading...

native/user-profile/user-profile.react.js

Loading...