services/commtest/build.rs
11–15	This is not a perfect solution. It can stay for now but we should design something else for long term. Can you create a follow-up task for this? E.g. under ENG-2311 or 4686

This revision is now accepted and ready to land.Oct 16 2023, 7:42 AM

varun added inline comments.Oct 19 2023, 2:20 AM

services/commtest/build.rs
11–15	https://linear.app/comm/issue/ENG-5297/compile-all-protobuf-files-in-grpc-clients-and-potentially-rename-the

Closed by commit rCOMM695f3464b34b: [commtest] use shared/grpc_client for identity clients. · Explain WhyOct 19 2023, 3:00 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM695f3464b34b: [commtest] use shared/grpc_client for identity clients.

Revision Contents
Changeset List

Path

Size

services/

commtest/

Cargo.lock

Cargo.toml

5 lines

build.rs

5 lines

src/

identity/

device.rs

29 lines

tests/

identity_access_tokens_tests.rs

39 lines

identity_keyserver_tests.rs

62 lines

identity_one_time_key_tests.rs

26 lines

identity_prekey_tests.rs

43 lines

identity_tunnelbroker_tests.rs

57 lines

Diff 31975

View Options

services/commtest/Cargo.lock

View Options

services/commtest/Cargo.toml

View Options

services/commtest/build.rs

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

View Options

services/commtest/tests/identity_keyserver_tests.rs

View Options

services/commtest/tests/identity_one_time_key_tests.rs

View Options

services/commtest/tests/identity_prekey_tests.rs

View Options

services/commtest/tests/identity_tunnelbroker_tests.rs

[commtest] use shared/grpc_client for identity clientsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 31975

services/commtest/Cargo.lock

services/commtest/Cargo.toml

services/commtest/build.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_keyserver_tests.rs

services/commtest/tests/identity_one_time_key_tests.rs

services/commtest/tests/identity_prekey_tests.rs

services/commtest/tests/identity_tunnelbroker_tests.rs

[commtest] use shared/grpc_client for identity clients
ClosedPublic
Actions

Revision Contents
Changeset List