pretty straightforward... just a no-op RPC that will return an unsupported version status code if the caller's code version is outdated. will set the actual unsupported versions for each platform when we launch.
Details
Details
called the RPC from kreya with metadata to trigger both an OK response and an unsupported version response
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Accepting, but please extract that version constant.
| services/identity/src/grpc_services/shared.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #31985) | Minor thing but what about calling it version_interceptor (verb -> noun)? |
| 10 ↗ | (On Diff #31985) | const MIN_SUPPORTED_NATIVE_VERSION: u64 = 270; we should definitely extract this as a constant. |
| services/identity/src/main.rs | ||
| 79 ↗ | (On Diff #31985) | I'd call it this way, doesn't matter tho. |
| shared/protos/identity_client.proto | ||
| 58–60 ↗ | (On Diff #31985) | I assume this is deleted because it's implemented in the "authenticated service", am I right? |
| services/identity/src/grpc_services/shared.rs | ||
|---|---|---|
| 5 ↗ | (On Diff #31985) | yeah interceptor makes more sense for sure. i was just copying the pattern introduced with the auth_intercept function. i'll change both to interceptor |
| 10 ↗ | (On Diff #31985) | yeah makes sense |
| shared/protos/identity_client.proto | ||
| 58–60 ↗ | (On Diff #31985) | that's right |