Page MenuHomePhabricator
Differential D9621

[lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector
ClosedPublic
Actions

Authored by inka on Oct 27 2023, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 12:09 AM
Unknown Object (File)
Thu, Apr 17, 12:09 AM
Unknown Object (File)
Mon, Apr 14, 8:34 PM
Unknown Object (File)
Sat, Apr 12, 7:26 PM
Unknown Object (File)
Sun, Mar 30, 3:44 PM
Unknown Object (File)
Mar 27 2025, 1:00 AM
Unknown Object (File)
Mar 10 2025, 8:42 AM
Unknown Object (File)
Mar 1 2025, 7:35 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector
Summary

issue: https://linear.app/comm/issue/ENG-4999/refactor-lastcommunicatedplatformdetailsselector

Test Plan

tested that the selector works - it is still possible to call the server using callServerEndpoint.

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 27 2023, 8:54 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 27 2023, 8:54 AM
Harbormaster completed remote builds in B23541: Diff 32466.Oct 27 2023, 9:17 AM
inka requested review of this revision.Oct 27 2023, 9:17 AM
inka added a child revision: D9680: [lib][web][native] Refactor connectionSelector.Nov 3 2023, 4:27 AM
inka updated this revision to Diff 32666.Nov 3 2023, 5:20 AM

Make code prettier

inka updated this revision to Diff 32670.Nov 3 2023, 5:30 AM

Make code prettier 2

Harbormaster completed remote builds in B23707: Diff 32666.Nov 3 2023, 5:41 AM
Harbormaster completed remote builds in B23711: Diff 32670.Nov 3 2023, 6:36 AM
kamil accepted this revision.Nov 7 2023, 2:58 AM
This revision is now accepted and ready to land.Nov 7 2023, 2:58 AM
Closed by commit rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector.

Revision Contents
Changeset List

PathSize
lib/
selectors/
15 lines
13 lines
utils/
5 lines
native/
3 lines
web/
3 lines

Diff 32466

View Options

lib/selectors/keyserver-selectors.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }
View Options

lib/selectors/server-calls.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }
View Options

lib/utils/action-utils.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }
View Options

native/socket.react.js

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Linesbutton.menuAction {
font-size: inherit; font-size: inherit;
} }
button.menuAction:hover { button.menuAction:hover {
color: var(--menu-color-hover); color: var(--menu-color-hover);
} }
div.menuActionIcon { div.menuActionIcon {
font-size: 1.125em;
display: flex; display: flex;
justify-content: center; justify-content: center;
margin-right: 8px; margin-right: 8px;
height: 24px;
width: 24px;
}
div.menuActionListMemberActions div.menuActionIcon {
height: 18px;
width: 18px;
} }
button.menuActionDangerous { button.menuActionDangerous {
color: var(--menu-color-dangerous); color: var(--menu-color-dangerous);
} }
button.menuActionDangerous:hover { button.menuActionDangerous:hover {
color: var(--menu-color-dangerous-hover); color: var(--menu-color-dangerous-hover);
} }
hr.separator { hr.separator {
height: 1px; height: 1px;
background: var(--menu-separator-color); background: var(--menu-separator-color);
margin: 10px 16px; margin: 10px 16px;
max-width: 130px; max-width: 130px;
border: none; border: none;
} }
View Options

web/socket.react.js

Loading...