Page MenuHomePhabricator
Differential D9621

[lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector
ClosedPublic
Actions

Authored by inka on Oct 27 2023, 8:54 AM.
Tags
None
Referenced Files
F3183299: D9621.id32670.diff
Fri, Nov 8, 8:49 AM
F3183284: D9621.id32666.diff
Fri, Nov 8, 8:46 AM
Unknown Object (File)
Sat, Nov 2, 6:20 PM
Unknown Object (File)
Mon, Oct 21, 4:03 AM
Unknown Object (File)
Oct 7 2024, 10:02 AM
Unknown Object (File)
Oct 7 2024, 10:02 AM
Unknown Object (File)
Oct 7 2024, 10:02 AM
Unknown Object (File)
Oct 7 2024, 10:02 AM
View All 75 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector
Summary

issue: https://linear.app/comm/issue/ENG-4999/refactor-lastcommunicatedplatformdetailsselector

Test Plan

tested that the selector works - it is still possible to call the server using callServerEndpoint.

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 27 2023, 8:54 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 27 2023, 8:54 AM
Harbormaster completed remote builds in B23541: Diff 32466.Oct 27 2023, 9:17 AM
inka requested review of this revision.Oct 27 2023, 9:17 AM
inka added a child revision: D9680: [lib][web][native] Refactor connectionSelector.Nov 3 2023, 4:27 AM
inka updated this revision to Diff 32666.Nov 3 2023, 5:20 AM

Make code prettier

inka updated this revision to Diff 32670.Nov 3 2023, 5:30 AM

Make code prettier 2

Harbormaster completed remote builds in B23707: Diff 32666.Nov 3 2023, 5:41 AM
Harbormaster completed remote builds in B23711: Diff 32670.Nov 3 2023, 6:36 AM
kamil accepted this revision.Nov 7 2023, 2:58 AM
This revision is now accepted and ready to land.Nov 7 2023, 2:58 AM
Closed by commit rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM0194e3f364c1: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector.

Revision Contents
Changeset List

PathSize
lib/
selectors/
15 lines
13 lines
utils/
5 lines
native/
3 lines
web/
3 lines

Diff 32466

View Options

lib/selectors/keyserver-selectors.js

Loading...
View Options

lib/selectors/server-calls.js

Loading...
View Options

lib/utils/action-utils.js

Loading...
View Options

native/socket.react.js

Loading...
View Options

web/socket.react.js

Loading...