[lib] implement creating Tunnelbroker socket
ClosedPublic
Actions

Authored by kamil on Oct 26 2023, 8:56 AM.

Details

Reviewers

Commits

Summary

Creates socket and implement initial handlers.

Depends on D9606

Test Plan

Tested in next diff.

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

kamil held this revision as a draft.

kamil published this revision for review.Oct 27 2023, 5:37 AM

kamil added inline comments.

lib/facts/tunnelbroker.js
6 ↗	(On Diff #32429)	I'll change this to staging after deployment and landing this stack, for now, I preferer this - it's easier for me to work on this.
lib/tunnelbroker/tunnelbroker-context.js
50–53 ↗	(On Diff #32429)	We should retry here, but I want to avoid unnecessary computation on the client right now, when the socket most likely will be closed because the clients are not logged in to Identity and auth will fail. Improving this is tracked here.

michal added inline comments.

lib/facts/tunnelbroker.js
6 ↗	(On Diff #32429)	Nit: can we change it to localhost?
lib/tunnelbroker/tunnelbroker-context.js
54–56 ↗	(On Diff #32429)	Should we close the connection here?

This revision is now accepted and ready to land.Oct 30 2023, 10:00 AM

use localhost

lib/facts/tunnelbroker.js
6 ↗	(On Diff #32429)	yes!
lib/tunnelbroker/tunnelbroker-context.js
54–56 ↗	(On Diff #32429)	As far as I know `close` and `error` comes along, but `close` is later (as a result of `error`) so it's usually better to handle only `close` events. link to standard