[lib][web][native] Refactor urlPrefixSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 4:45 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector

Summary

issue: https://linear.app/comm/issue/ENG-5001/refactor-urlprefixselector

Test Plan

Tested that the selector works by calling useSelector(urlPrefixSelector('256')); and printing the result. Tested the openSocketSelector by running the app and checking that it is possible to send messages

Diff Detail

Repository

rCOMM Comm

Branch

inka/actions_new_branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Nov 3 2023, 4:45 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 4:45 AM

inka added a parent revision: D9680: [lib][web][native] Refactor connectionSelector.Nov 3 2023, 4:46 AM

Harbormaster completed remote builds in B23704: Diff 32663.Nov 3 2023, 5:03 AM

inka requested review of this revision.Nov 3 2023, 5:03 AM

Make code prettier

Harbormaster completed remote builds in B23709: Diff 32668.Nov 3 2023, 5:56 AM

inka added a child revision: D9684: [lib][web][native] Refactor currentAsOfSelector.Nov 3 2023, 6:56 AM

kamil accepted this revision.Nov 7 2023, 3:03 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:03 AM

Closed by commit rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM76e89cffbe41: [lib][web][native] Refactor urlPrefixSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

8 lines

server-calls.js

2 lines

native/

account/

logged-out-modal.react.js

2 lines

data/

sqlite-data-handler.js

2 lines

profile/

custom-server-modal.react.js

3 lines

dev-tools.react.js

3 lines

selectors/

socket-selectors.js

11 lines

socket.react.js

4 lines

web/

selectors/

socket-selectors.js

11 lines

socket.react.js

4 lines

Diff 32663

View Options

lib/selectors/keyserver-selectors.js

Show All 34 Lines	void AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);		this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) {		this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message		LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect";		<< ", will try to reconnect";
this->amqpReady = false;		this->amqpReady = false;
});		});

AMQP::Table arguments;		AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;		arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL;		arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);		this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)		this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName](		.onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name,		const std::string &name,
uint32_t messagecount,		uint32_t messagecount,
uint32_t consumercount) {		uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created";		LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")		this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

View Options

lib/selectors/server-calls.js

Show All 34 Lines	void AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);		this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) {		this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message		LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect";		<< ", will try to reconnect";
this->amqpReady = false;		this->amqpReady = false;
});		});

AMQP::Table arguments;		AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;		arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL;		arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);		this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)		this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName](		.onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name,		const std::string &name,
uint32_t messagecount,		uint32_t messagecount,
uint32_t consumercount) {		uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created";		LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")		this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

View Options

native/account/logged-out-modal.react.js

Show All 34 Lines	void AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);		this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) {		this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message		LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect";		<< ", will try to reconnect";
this->amqpReady = false;		this->amqpReady = false;
});		});

AMQP::Table arguments;		AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;		arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL;		arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);		this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)		this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName](		.onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name,		const std::string &name,
uint32_t messagecount,		uint32_t messagecount,
uint32_t consumercount) {		uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created";		LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")		this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

View Options

native/data/sqlite-data-handler.js

Show All 34 Lines	void AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);		this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) {		this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message		LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect";		<< ", will try to reconnect";
this->amqpReady = false;		this->amqpReady = false;
});		});

AMQP::Table arguments;		AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;		arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL;		arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);		this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)		this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName](		.onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name,		const std::string &name,
uint32_t messagecount,		uint32_t messagecount,
uint32_t consumercount) {		uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created";		LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")		this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines

View Options

native/profile/custom-server-modal.react.js

Show All 34 Lines	void AmqpManager::connectInternal() {
this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);		this->amqpChannel = std::make_unique<AMQP::TcpChannel>(&connection);
this->amqpChannel->onError([this](const char *message) {		this->amqpChannel->onError([this](const char *message) {
LOG(ERROR) << "AMQP: channel error: " << message		LOG(ERROR) << "AMQP: channel error: " << message
<< ", will try to reconnect";		<< ", will try to reconnect";
this->amqpReady = false;		this->amqpReady = false;
});		});

AMQP::Table arguments;		AMQP::Table arguments;
arguments["x-message-ttl"] = AMQP_MESSAGE_TTL;		arguments["x-message-ttl"] = (uint64_t)AMQP_MESSAGE_TTL;
arguments["x-expires"] = AMQP_QUEUE_TTL;		arguments["x-expires"] = (uint64_t)AMQP_QUEUE_TTL;
this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);		this->amqpChannel->declareExchange(fanoutExchangeName, AMQP::fanout);
this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)		this->amqpChannel->declareQueue(tunnelbrokerID, AMQP::durable, arguments)
.onSuccess([this, tunnelbrokerID, fanoutExchangeName](		.onSuccess([this, tunnelbrokerID, fanoutExchangeName](
const std::string &name,		const std::string &name,
uint32_t messagecount,		uint32_t messagecount,
uint32_t consumercount) {		uint32_t consumercount) {
LOG(INFO) << "AMQP: Queue " << name << " created";		LOG(INFO) << "AMQP: Queue " << name << " created";
this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")		this->amqpChannel->bindQueue(fanoutExchangeName, tunnelbrokerID, "")
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines