Paths

Table of Contentst

[lib][web][native] Refactor connectionSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 4:27 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector

Summary

issue: https://linear.app/comm/issue/ENG-5000/refactor-connectionselector

Test Plan

Tested that the selector works by calling useSelector(connectionSelector('256')); and printing the result

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Nov 3 2023, 4:27 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 4:27 AM

inka added a parent revision: D9621: [lib][web][native] Refactor lastCommunicatedPlatformDetailsSelector.Nov 3 2023, 4:27 AM

Harbormaster completed remote builds in B23703: Diff 32662.Nov 3 2023, 4:45 AM

inka requested review of this revision.Nov 3 2023, 4:45 AM

inka added a child revision: D9681: [lib][web][native] Refactor urlPrefixSelector.Nov 3 2023, 4:46 AM

Make code prettier

Harbormaster completed remote builds in B23710: Diff 32669.Nov 3 2023, 6:20 AM

kamil accepted this revision.Nov 7 2023, 3:01 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:01 AM

Closed by commit rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM595ebc3b8ea2: [lib][web][native] Refactor connectionSelector.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

disconnected-bar.js

5 lines

selectors/

keyserver-selectors.js

11 lines

server-calls.js

2 lines

socket/

activity-handler.react.js

3 lines

api-request-handler.react.js

3 lines

calendar-query-handler.react.js

3 lines

request-response-handler.react.js

3 lines

update-handler.react.js

3 lines

native/

calendar/

calendar.react.js

3 lines

entry.react.js

3 lines

media/

encrypted-image.react.js

3 lines

remote-image.react.js

3 lines

push/

push-handler.react.js

2 lines

socket.react.js

2 lines

web/

calendar/

entry.react.js

3 lines

push-notif/

badge-handler.react.js

3 lines

socket.react.js

2 lines

Diff 32669

View Options

lib/hooks/disconnected-bar.js

View Options

lib/selectors/keyserver-selectors.js

View Options

lib/selectors/server-calls.js

View Options

lib/socket/activity-handler.react.js

View Options

lib/socket/api-request-handler.react.js

View Options

lib/socket/calendar-query-handler.react.js

View Options

lib/socket/request-response-handler.react.js

View Options

lib/socket/update-handler.react.js

View Options

native/calendar/calendar.react.js

View Options

native/calendar/entry.react.js

View Options

native/media/encrypted-image.react.js

View Options

native/media/remote-image.react.js

View Options

native/push/push-handler.react.js

View Options

native/socket.react.js

View Options

web/calendar/entry.react.js

View Options

web/push-notif/badge-handler.react.js

View Options

[lib][web][native] Refactor connectionSelectorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32669

lib/hooks/disconnected-bar.js

lib/selectors/keyserver-selectors.js

lib/selectors/server-calls.js

lib/socket/activity-handler.react.js

lib/socket/api-request-handler.react.js

lib/socket/calendar-query-handler.react.js

lib/socket/request-response-handler.react.js

lib/socket/update-handler.react.js

native/calendar/calendar.react.js

native/calendar/entry.react.js

native/media/encrypted-image.react.js

native/media/remote-image.react.js

native/push/push-handler.react.js

native/socket.react.js

web/calendar/entry.react.js

web/push-notif/badge-handler.react.js

web/socket.react.js

[lib][web][native] Refactor connectionSelector
ClosedPublic
Actions

Revision Contents
Changeset List