Page MenuHomePhabricator
Differential D9684

[lib][web][native] Refactor currentAsOfSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 6:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 4:16 PM
Unknown Object (File)
Tue, Mar 25, 6:26 PM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:29 AM
Unknown Object (File)
Feb 3 2025, 4:00 PM
Unknown Object (File)
Feb 3 2025, 4:00 PM
View All 67 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM6cdf4f96d84b: [lib][web][native] Refactor currentAsOfSelector
Summary

issue: https://linear.app/comm/issue/ENG-5002/refactor-currentasofselector

Test Plan

Tested currentAsOfSelector, sessionStateFuncSelector, noDataAfterPolicyAcknowledgmentSelector by calling useSelector(selector('256')); and printing the result. Tested the openSocketSelector by running the app and checking that it is possible to send messages

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
selectors/
10 lines
42 lines
native/
selectors/
13 lines
27 lines
4 lines
web/
selectors/
12 lines
4 lines

Diff 32675

View Options

lib/selectors/keyserver-selectors.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines
View Options

lib/selectors/socket-selectors.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines
View Options

native/selectors/account-selectors.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines
View Options

native/selectors/socket-selectors.js

// Top-level build file where you can add configuration options common to all sub-projects/modules. // Top-level build file where you can add configuration options common to all sub-projects/modules.
buildscript { buildscript {
ext { ext {
buildToolsVersion = "31.0.0" buildToolsVersion = "31.0.0"
minSdkVersion = 21 minSdkVersion = 21
compileSdkVersion = 31 compileSdkVersion = 31
targetSdkVersion = 31 targetSdkVersion = 31
// We can't use NDK 24 yet because of Folly build issues if (System.properties['os.arch'] == "aarch64") {
// https://linear.app/comm/issue/ENG-2169/update-folly-on-android // For M1 Users we need to use the NDK 24 which added support for aarch64
//if (System.properties['os.arch'] == "aarch64") { ndkVersion = "24.0.8215888"
// // For M1 Users we need to use the NDK 24 which added support for aarch64 } else {
// ndkVersion = "24.0.8215888" // Otherwise we default to the side-by-side NDK version from AGP.
//} else {
// // Otherwise we default to the side-by-side NDK version from AGP.
// ndkVersion = "21.4.7075529"
//}
ndkVersion = "21.4.7075529" ndkVersion = "21.4.7075529"
} }
}
repositories { repositories {
google() google()
mavenCentral() mavenCentral()
} }
dependencies { dependencies {
classpath("com.android.tools.build:gradle:7.2.1") classpath("com.android.tools.build:gradle:7.2.1")
classpath("com.facebook.react:react-native-gradle-plugin") classpath("com.facebook.react:react-native-gradle-plugin")
classpath("de.undercouch:gradle-download-task:5.0.1") classpath("de.undercouch:gradle-download-task:5.0.1")
Show All 35 Lines
View Options

native/socket.react.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...
View Options

web/socket.react.js

Loading...