Details

Reviewers

michal
bartek
tomek

Commits

rCOMMc27a38ae2582: [lib] handle Tunnelbroker messages

Summary

This is the initial version of handling messages received from Tunnelbroker.

Depends on D9610

Test Plan

I used some Rust code to verify its operation, for example, to confirm if the device properly acknowledges a MessageToDevice on both web/native platforms.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Oct 26 2023, 9:22 AM

kamil held this revision as a draft.

Herald added subscribers: will, ashoat. · View Herald TranscriptOct 26 2023, 9:22 AM

Harbormaster failed remote builds in B23516: Diff 32433!Oct 26 2023, 9:33 AM

kamil added a child revision: D9616: [lib] implement sending messages to Tunnelbroker.Oct 27 2023, 4:37 AM

Harbormaster completed remote builds in B23529: Diff 32454.Oct 27 2023, 4:51 AM

kamil published this revision for review.Oct 27 2023, 5:39 AM

michal added inline comments.Nov 2 2023, 7:24 AM

lib/tunnelbroker/tunnelbroker-context.js
66 ↗	(On Diff #32454)	We should add a `try` for this

address review

Harbormaster completed remote builds in B23675: Diff 32629.Nov 2 2023, 10:28 AM

ashoat added inline comments.Nov 2 2023, 10:54 AM

lib/tunnelbroker/tunnelbroker-context.js
72 ↗	(On Diff #32629)	Historically React Native has not handled `console.error` and `console.warn` very well: https://github.com/facebook/react-native/issues?q=is%3Aissue+in%3Atitle+%22console.warn%22+is%3Aclosed, https://github.com/facebook/react-native/issues?q=is%3Aissue+in%3Atitle+%22console.error%22+is%3Aclosed+ Might be worth testing to make sure this doesn't break anything. You could also consider just using `console.log`