[lib][web][native] Refactor cookieSelector
ClosedPublic
Actions

Authored by inka on Nov 6 2023, 9:45 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM16501e45b860: [lib][web][native] Refactor cookieSelector

Summary

issue: https://linear.app/comm/issue/ENG-5005/refactor-cookieselector

Test Plan

Tested that ther refactored selectors work

Diff Detail

Repository

rCOMM Comm

Branch

inka/actions_new_branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Nov 6 2023, 9:45 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 6 2023, 9:45 AM

inka added a parent revision: D9732: [lib][web][native] Refactor sessionIDSelector.Nov 6 2023, 9:45 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 6 2023, 10:34 AM

Harbormaster failed remote builds in B23807: Diff 32820!

Harbormaster completed remote builds in B23807: Diff 32820.Nov 7 2023, 1:20 AM

inka requested review of this revision.Nov 7 2023, 1:20 AM

kamil accepted this revision.Nov 7 2023, 3:26 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:26 AM

Closed by commit rCOMM16501e45b860: [lib][web][native] Refactor cookieSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM16501e45b860: [lib][web][native] Refactor cookieSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

account-selectors.js

2 lines

keyserver-selectors.js

10 lines

server-calls.js

2 lines

shared/

session-utils.js

2 lines

native/

account/

logged-out-modal.react.js

2 lines

data/

sqlite-data-handler.js

2 lines

navigation/

navigation-handler.react.js

3 lines

selectors/

socket-selectors.js

17 lines

socket.react.js

6 lines

web/

selectors/

socket-selectors.js

2 lines

socket.react.js

2 lines

Diff 32820

View Options

lib/selectors/account-selectors.js

View Options

lib/selectors/keyserver-selectors.js

View Options

lib/selectors/server-calls.js

View Options

lib/shared/session-utils.js

View Options

native/account/logged-out-modal.react.js

View Options

native/data/sqlite-data-handler.js

View Options

native/navigation/navigation-handler.react.js

View Options

native/selectors/socket-selectors.js

View Options

native/socket.react.js

View Options

web/selectors/socket-selectors.js

View Options

[lib][web][native] Refactor cookieSelectorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32820

lib/selectors/account-selectors.js

lib/selectors/keyserver-selectors.js

lib/selectors/server-calls.js

lib/shared/session-utils.js

native/account/logged-out-modal.react.js

native/data/sqlite-data-handler.js

native/navigation/navigation-handler.react.js

native/selectors/socket-selectors.js

native/socket.react.js

web/selectors/socket-selectors.js

web/socket.react.js

[lib][web][native] Refactor cookieSelector
ClosedPublic
Actions

Revision Contents
Changeset List