Page MenuHomePhabricator
Differential D9733

[lib][web][native] Refactor cookieSelector
ClosedPublic
Actions

Authored by inka on Nov 6 2023, 9:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 6:26 PM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:35 AM
Unknown Object (File)
Mar 1 2025, 7:29 AM
Unknown Object (File)
Feb 18 2025, 9:40 AM
Unknown Object (File)
Feb 14 2025, 9:44 AM
Unknown Object (File)
Feb 3 2025, 4:00 PM
View All 71 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM16501e45b860: [lib][web][native] Refactor cookieSelector
Summary

issue: https://linear.app/comm/issue/ENG-5005/refactor-cookieselector

Test Plan

Tested that ther refactored selectors work

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
selectors/
2 lines
10 lines
2 lines
shared/
2 lines
native/
account/
2 lines
data/
2 lines
navigation/
3 lines
selectors/
17 lines
6 lines
web/
selectors/
2 lines
2 lines

Diff 32820

View Options

lib/selectors/account-selectors.js

// @flow // @flow
import { import {
setThreadUnreadStatusResult, setThreadUnreadStatusResult,
updateActivityResultValidator, updateActivityResultValidator,
} from 'lib/types/activity-types.js'; } from 'lib/types/activity-types.js';
import { import {
fetchEntryInfosResponseValidator, fetchEntryInfosResponseValidator,
fetchEntryRevisionInfosResultValidator, fetchEntryRevisionInfosResultValidator,
saveEntryResponseValidator, saveEntryResponseValidator,
deleteEntryResponseValidator, deleteEntryResponseValidator,
deltaEntryInfosResultValidator, deltaEntryInfosResultValidator,
restoreEntryResponseValidator, restoreEntryResponseValidator,
} from './entry-responders.js'; } from './entry-responders.js';
import { getSessionPublicKeysResponseValidator } from './keys-responders.js'; import { getSessionPublicKeysResponseValidator } from './keys-responders.js';
import { inviteLinkVerificationResponseValidator } from './link-responders.js'; import {
inviteLinkVerificationResponseValidator,
fetchInviteLinksResponseValidator,
} from './link-responders.js';
import { messageReportCreationResultValidator } from './message-report-responder.js'; import { messageReportCreationResultValidator } from './message-report-responder.js';
import { import {
fetchMessageInfosResponseValidator, fetchMessageInfosResponseValidator,
fetchPinnedMessagesResultValidator, fetchPinnedMessagesResultValidator,
sendEditMessageResponseValidator, sendEditMessageResponseValidator,
sendMessageResponseValidator, sendMessageResponseValidator,
} from './message-responders.js'; } from './message-responders.js';
import { relationshipErrorsValidator } from './relationship-responders.js'; import { relationshipErrorsValidator } from './relationship-responders.js';
▲ Show 20 Lines • Show All 921 Lines • ▼ Show 20 Lines const response = {
community: { community: {
name: 'name', name: 'name',
id: '123', id: '123',
}, },
}; };
expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true); expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true);
expect(inviteLinkVerificationResponseValidator.is({})).toBe(false); expect(inviteLinkVerificationResponseValidator.is({})).toBe(false);
}); });
it('should validate invite link verification response', () => {
const response = {
links: [
{
name: 'name',
primary: true,
role: '123',
communityID: '123',
expirationTime: 123,
limitOfUses: 123,
numberOfUses: 123,
},
],
};
expect(fetchInviteLinksResponseValidator.is(response)).toBe(true);
expect(fetchInviteLinksResponseValidator.is({ links: {} })).toBe(false);
});
}); });
View Options

lib/selectors/keyserver-selectors.js

// @flow // @flow
import { import {
setThreadUnreadStatusResult, setThreadUnreadStatusResult,
updateActivityResultValidator, updateActivityResultValidator,
} from 'lib/types/activity-types.js'; } from 'lib/types/activity-types.js';
import { import {
fetchEntryInfosResponseValidator, fetchEntryInfosResponseValidator,
fetchEntryRevisionInfosResultValidator, fetchEntryRevisionInfosResultValidator,
saveEntryResponseValidator, saveEntryResponseValidator,
deleteEntryResponseValidator, deleteEntryResponseValidator,
deltaEntryInfosResultValidator, deltaEntryInfosResultValidator,
restoreEntryResponseValidator, restoreEntryResponseValidator,
} from './entry-responders.js'; } from './entry-responders.js';
import { getSessionPublicKeysResponseValidator } from './keys-responders.js'; import { getSessionPublicKeysResponseValidator } from './keys-responders.js';
import { inviteLinkVerificationResponseValidator } from './link-responders.js'; import {
inviteLinkVerificationResponseValidator,
fetchInviteLinksResponseValidator,
} from './link-responders.js';
import { messageReportCreationResultValidator } from './message-report-responder.js'; import { messageReportCreationResultValidator } from './message-report-responder.js';
import { import {
fetchMessageInfosResponseValidator, fetchMessageInfosResponseValidator,
fetchPinnedMessagesResultValidator, fetchPinnedMessagesResultValidator,
sendEditMessageResponseValidator, sendEditMessageResponseValidator,
sendMessageResponseValidator, sendMessageResponseValidator,
} from './message-responders.js'; } from './message-responders.js';
import { relationshipErrorsValidator } from './relationship-responders.js'; import { relationshipErrorsValidator } from './relationship-responders.js';
▲ Show 20 Lines • Show All 921 Lines • ▼ Show 20 Lines const response = {
community: { community: {
name: 'name', name: 'name',
id: '123', id: '123',
}, },
}; };
expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true); expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true);
expect(inviteLinkVerificationResponseValidator.is({})).toBe(false); expect(inviteLinkVerificationResponseValidator.is({})).toBe(false);
}); });
it('should validate invite link verification response', () => {
const response = {
links: [
{
name: 'name',
primary: true,
role: '123',
communityID: '123',
expirationTime: 123,
limitOfUses: 123,
numberOfUses: 123,
},
],
};
expect(fetchInviteLinksResponseValidator.is(response)).toBe(true);
expect(fetchInviteLinksResponseValidator.is({ links: {} })).toBe(false);
});
}); });
View Options

lib/selectors/server-calls.js

// @flow // @flow
import { import {
setThreadUnreadStatusResult, setThreadUnreadStatusResult,
updateActivityResultValidator, updateActivityResultValidator,
} from 'lib/types/activity-types.js'; } from 'lib/types/activity-types.js';
import { import {
fetchEntryInfosResponseValidator, fetchEntryInfosResponseValidator,
fetchEntryRevisionInfosResultValidator, fetchEntryRevisionInfosResultValidator,
saveEntryResponseValidator, saveEntryResponseValidator,
deleteEntryResponseValidator, deleteEntryResponseValidator,
deltaEntryInfosResultValidator, deltaEntryInfosResultValidator,
restoreEntryResponseValidator, restoreEntryResponseValidator,
} from './entry-responders.js'; } from './entry-responders.js';
import { getSessionPublicKeysResponseValidator } from './keys-responders.js'; import { getSessionPublicKeysResponseValidator } from './keys-responders.js';
import { inviteLinkVerificationResponseValidator } from './link-responders.js'; import {
inviteLinkVerificationResponseValidator,
fetchInviteLinksResponseValidator,
} from './link-responders.js';
import { messageReportCreationResultValidator } from './message-report-responder.js'; import { messageReportCreationResultValidator } from './message-report-responder.js';
import { import {
fetchMessageInfosResponseValidator, fetchMessageInfosResponseValidator,
fetchPinnedMessagesResultValidator, fetchPinnedMessagesResultValidator,
sendEditMessageResponseValidator, sendEditMessageResponseValidator,
sendMessageResponseValidator, sendMessageResponseValidator,
} from './message-responders.js'; } from './message-responders.js';
import { relationshipErrorsValidator } from './relationship-responders.js'; import { relationshipErrorsValidator } from './relationship-responders.js';
▲ Show 20 Lines • Show All 921 Lines • ▼ Show 20 Lines const response = {
community: { community: {
name: 'name', name: 'name',
id: '123', id: '123',
}, },
}; };
expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true); expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true);
expect(inviteLinkVerificationResponseValidator.is({})).toBe(false); expect(inviteLinkVerificationResponseValidator.is({})).toBe(false);
}); });
it('should validate invite link verification response', () => {
const response = {
links: [
{
name: 'name',
primary: true,
role: '123',
communityID: '123',
expirationTime: 123,
limitOfUses: 123,
numberOfUses: 123,
},
],
};
expect(fetchInviteLinksResponseValidator.is(response)).toBe(true);
expect(fetchInviteLinksResponseValidator.is({ links: {} })).toBe(false);
});
}); });
View Options

lib/shared/session-utils.js

// @flow // @flow
import { import {
setThreadUnreadStatusResult, setThreadUnreadStatusResult,
updateActivityResultValidator, updateActivityResultValidator,
} from 'lib/types/activity-types.js'; } from 'lib/types/activity-types.js';
import { import {
fetchEntryInfosResponseValidator, fetchEntryInfosResponseValidator,
fetchEntryRevisionInfosResultValidator, fetchEntryRevisionInfosResultValidator,
saveEntryResponseValidator, saveEntryResponseValidator,
deleteEntryResponseValidator, deleteEntryResponseValidator,
deltaEntryInfosResultValidator, deltaEntryInfosResultValidator,
restoreEntryResponseValidator, restoreEntryResponseValidator,
} from './entry-responders.js'; } from './entry-responders.js';
import { getSessionPublicKeysResponseValidator } from './keys-responders.js'; import { getSessionPublicKeysResponseValidator } from './keys-responders.js';
import { inviteLinkVerificationResponseValidator } from './link-responders.js'; import {
inviteLinkVerificationResponseValidator,
fetchInviteLinksResponseValidator,
} from './link-responders.js';
import { messageReportCreationResultValidator } from './message-report-responder.js'; import { messageReportCreationResultValidator } from './message-report-responder.js';
import { import {
fetchMessageInfosResponseValidator, fetchMessageInfosResponseValidator,
fetchPinnedMessagesResultValidator, fetchPinnedMessagesResultValidator,
sendEditMessageResponseValidator, sendEditMessageResponseValidator,
sendMessageResponseValidator, sendMessageResponseValidator,
} from './message-responders.js'; } from './message-responders.js';
import { relationshipErrorsValidator } from './relationship-responders.js'; import { relationshipErrorsValidator } from './relationship-responders.js';
▲ Show 20 Lines • Show All 921 Lines • ▼ Show 20 Lines const response = {
community: { community: {
name: 'name', name: 'name',
id: '123', id: '123',
}, },
}; };
expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true); expect(inviteLinkVerificationResponseValidator.is(response)).toBe(true);
expect(inviteLinkVerificationResponseValidator.is({})).toBe(false); expect(inviteLinkVerificationResponseValidator.is({})).toBe(false);
}); });
it('should validate invite link verification response', () => {
const response = {
links: [
{
name: 'name',
primary: true,
role: '123',
communityID: '123',
expirationTime: 123,
limitOfUses: 123,
numberOfUses: 123,
},
],
};
expect(fetchInviteLinksResponseValidator.is(response)).toBe(true);
expect(fetchInviteLinksResponseValidator.is({ links: {} })).toBe(false);
});
}); });
View Options

native/account/logged-out-modal.react.js

Loading...
View Options

native/data/sqlite-data-handler.js

Loading...
View Options

native/navigation/navigation-handler.react.js

Loading...
View Options

native/selectors/socket-selectors.js

Loading...
View Options

native/socket.react.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...
View Options

web/socket.react.js

Loading...