Differential D9684

[lib][web][native] Refactor currentAsOfSelector
ClosedPublic
Actions

Authored by inka on Nov 3 2023, 6:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 2, 5:13 PM

	Unknown Object (File)
	Fri, Oct 11, 5:29 AM

	Unknown Object (File)
	Oct 7 2024, 10:02 AM

	Unknown Object (File)
	Oct 7 2024, 10:02 AM

	Unknown Object (File)
	Oct 7 2024, 10:01 AM

	Unknown Object (File)
	Oct 7 2024, 9:55 AM

	Unknown Object (File)
	Oct 5 2024, 10:16 PM

	Unknown Object (File)
	Sep 2 2024, 12:02 AM

View All 49 Files

Subscribers

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM6cdf4f96d84b: [lib][web][native] Refactor currentAsOfSelector

Summary

issue: https://linear.app/comm/issue/ENG-5002/refactor-currentasofselector

Test Plan

Tested currentAsOfSelector, sessionStateFuncSelector, noDataAfterPolicyAcknowledgmentSelector by calling useSelector(selector('256')); and printing the result. Tested the openSocketSelector by running the app and checking that it is possible to send messages

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Nov 3 2023, 6:56 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 3 2023, 6:56 AM

inka added a parent revision: D9681: [lib][web][native] Refactor urlPrefixSelector.Nov 3 2023, 6:56 AM

inka added a child revision: D9685: [lib][web][native] Refactor updatesCurrentAsOfSelector.Nov 3 2023, 7:03 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 3 2023, 7:28 AM

Harbormaster failed remote builds in B23716: Diff 32675!

Harbormaster completed remote builds in B23716: Diff 32675.Nov 3 2023, 7:47 AM

inka requested review of this revision.Nov 3 2023, 7:47 AM

kamil accepted this revision.Nov 7 2023, 3:08 AM

This revision is now accepted and ready to land.Nov 7 2023, 3:08 AM

Closed by commit rCOMM6cdf4f96d84b: [lib][web][native] Refactor currentAsOfSelector (authored by inka). · Explain WhyNov 9 2023, 1:41 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM6cdf4f96d84b: [lib][web][native] Refactor currentAsOfSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

keyserver-selectors.js

10 lines

socket-selectors.js

42 lines

native/

selectors/

account-selectors.js

13 lines

socket-selectors.js

27 lines

socket.react.js

4 lines

web/

selectors/

socket-selectors.js

12 lines

socket.react.js

4 lines

Diff 32994

lib/selectors/keyserver-selectors.js

Loading...

lib/selectors/socket-selectors.js

Loading...

native/selectors/account-selectors.js

Loading...

native/selectors/socket-selectors.js

Loading...

native/socket.react.js

Loading...

web/selectors/socket-selectors.js

Loading...

web/socket.react.js

Loading...