Page MenuHomePhabricator
Differential D9820

[lib] Refactor keyserver reducer pt.2 - early return
ClosedPublic
Actions

Authored by inka on Nov 10 2023, 6:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 10:35 PM
Unknown Object (File)
Thu, Nov 14, 9:05 PM
Unknown Object (File)
Thu, Nov 14, 8:00 PM
Unknown Object (File)
Thu, Nov 14, 5:53 PM
Unknown Object (File)
Oct 28 2024, 12:01 AM
Unknown Object (File)
Oct 23 2024, 10:07 AM
Unknown Object (File)
Oct 23 2024, 8:42 AM
Unknown Object (File)
Oct 11 2024, 2:20 AM
View All 79 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM4c0217553e46: [lib] Refactor keyserver reducer pt.2 - early return
Summary

issue: https://linear.app/comm/issue/ENG-5350/refactor-reducekeyserverstore
Now that the reducers this reducer used to call got inlined, we can early return from the keyserver reducer

Test Plan

Tested a couple of actions: queueActivityUpdatesActionType, updateDisconnectedBarActionType, updateActivityActionTypes.success, updateConnectionStatusActionType, checked that they work as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Nov 10 2023, 6:14 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 10 2023, 6:14 AM
inka added a parent revision: D9816: [lib] Inline reduceDeviceToken.Nov 10 2023, 6:14 AM
Harbormaster completed remote builds in B23995: Diff 33069.Nov 10 2023, 7:02 AM
inka requested review of this revision.Nov 10 2023, 7:02 AM
ginsu mentioned this in D9829: [lib] introduce removeKeyserverActionType condition to keyserver reducer.Nov 10 2023, 11:59 AM
inka updated this revision to Diff 33204.Nov 14 2023, 1:14 AM

Rebase

Harbormaster completed remote builds in B24104: Diff 33204.Nov 14 2023, 2:12 AM
inka added a child revision: D9879: [keyserver][lib] Update freshMessageStore to return currentAsOf for all keyservers.Nov 14 2023, 2:18 AM
michal requested changes to this revision.Nov 14 2023, 6:17 AM
michal added inline comments.
lib/reducers/keyserver-reducer.js
67–92 ↗(On Diff #33204)

Return should be after these two ifs

99 ↗(On Diff #33204)

We should return after outside of for

This revision now requires changes to proceed.Nov 14 2023, 6:17 AM
inka updated this revision to Diff 33211.Nov 14 2023, 6:51 AM

Fix returns from ifs and loop

michal added inline comments.Nov 14 2023, 7:00 AM
lib/reducers/keyserver-reducer.js
101–108

I don't think that's correct

Harbormaster completed remote builds in B24111: Diff 33211.Nov 14 2023, 7:14 AM
ginsu mentioned this in rCOMMb89136d8d288: [lib] introduce removeKeyserverActionType condition to keyserver reducer.Nov 14 2023, 5:49 PM
inka updated this revision to Diff 33319.Nov 16 2023, 1:45 AM

Rebase, adderess review

Harbormaster completed remote builds in B24195: Diff 33319.Nov 16 2023, 2:30 AM
michal accepted this revision.Nov 16 2023, 5:06 AM
This revision is now accepted and ready to land.Nov 16 2023, 5:06 AM
Closed by commit rCOMM4c0217553e46: [lib] Refactor keyserver reducer pt.2 - early return (authored by inka). · Explain WhyNov 22 2023, 7:24 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM4c0217553e46: [lib] Refactor keyserver reducer pt.2 - early return.
inka mentioned this in D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.Jan 22 2024, 8:17 AM

Revision Contents
Changeset List

PathSize
lib/
reducers/
49 lines

Diff 33211

View Options

lib/reducers/keyserver-reducer.js

Loading...