Page MenuHomePhabricator
Differential D9891

[web] introduce keyserver selection list item
ClosedPublic
Actions

Authored by ginsu on Nov 14 2023, 8:10 PM.
Tags
None
Referenced Files
F3181605: D9891.id33249.diff
Fri, Nov 8, 6:37 AM
F3180264: D9891.diff
Fri, Nov 8, 4:32 AM
Unknown Object (File)
Tue, Nov 5, 2:13 AM
Unknown Object (File)
Sat, Oct 19, 3:39 AM
Unknown Object (File)
Tue, Oct 15, 1:44 AM
Unknown Object (File)
Tue, Oct 15, 1:42 AM
Unknown Object (File)
Wed, Oct 9, 2:44 PM
Unknown Object (File)
Sep 27 2024, 1:01 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
rohan
michal
Commits
rCOMM0b8e58dacd3f: [web] introduce keyserver selection list item
Summary

introduce KeyserverSelectionListItem component. This component will be used in the keyserver selection list.

For context here are the figma designs:

Screenshot 2023-11-14 at 5.26.24 PM.png (274×676 px, 22 KB)

Linear task: https://linear.app/comm/issue/ENG-5493/introduce-keyserver-list-item-ui

Depends on D9905

Test Plan

Please see screenshots below (please note the blue add button is temporary and is not part of this diff)

Screenshot 2023-11-14 at 11.11.55 PM.png (2×3 px, 804 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 14 2023, 8:10 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 14 2023, 8:10 PM
ginsu edited the summary of this revision. (Show Details)Nov 14 2023, 8:14 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, rohan, michal.
ginsu added a parent revision: D9888: [web] introduce status indicator component.
ginsu attached a referenced file: F877580: Screenshot 2023-11-14 at 11.11.55 PM.png. (Show Details)
ginsu attached a referenced file: F877584: Screenshot 2023-11-14 at 5.26.24 PM.png. (Show Details)
ginsu added a child revision: D9892: [web] introduce keyserver selection list.Nov 14 2023, 8:21 PM
Harbormaster completed remote builds in B24138: Diff 33249.Nov 14 2023, 8:33 PM
ginsu requested review of this revision.Nov 14 2023, 8:33 PM
ginsu edited the summary of this revision. (Show Details)Nov 15 2023, 1:25 PM
ginsu added a parent revision: D9905: [web] introduce keyserver pill component.
ginsu removed a parent revision: D9888: [web] introduce status indicator component.
ginsu updated this revision to Diff 33302.Nov 15 2023, 1:32 PM

update

Harbormaster failed remote builds in B24184: Diff 33302!Nov 15 2023, 4:32 PM
inka accepted this revision.Nov 16 2023, 8:23 AM
This revision is now accepted and ready to land.Nov 16 2023, 8:23 AM
ginsu updated this revision to Diff 33611.Nov 26 2023, 6:06 PM

rebase before landing

Harbormaster completed remote builds in B24412: Diff 33611.Nov 26 2023, 6:27 PM
Closed by commit rCOMM0b8e58dacd3f: [web] introduce keyserver selection list item (authored by ginsu). · Explain WhyNov 26 2023, 8:18 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM0b8e58dacd3f: [web] introduce keyserver selection list item.

Revision Contents
Changeset List

Diff 33249

View Options

web/settings/keyserver-selection-list-item.css

Loading...
View Options

web/settings/keyserver-selection-list-item.react.js

Loading...