Paths

Table of Contentst

Differential D9904

[SQLite] add methods to operate on users table
ClosedPublic
Actions

Authored by kamil on Nov 15 2023, 8:28 PM.

Tags

None

Referenced Files

	F33330644: D9904.1768882400.diff
	Mon, Jan 19, 4:13 AM

Subscribers

Details

Reviewers

Commits

rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table

Summary

Representation of data row.
Methods to modify table.
Emscripten bindings

Depends on D9903

Test Plan

Tests in D9909

Diff Detail

Repository

Branch

user-store-work

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Nov 15 2023, 8:28 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptNov 15 2023, 8:28 PM

Harbormaster completed remote builds in B24182: Diff 33300.Nov 15 2023, 11:52 PM

refactor

kamil added a child revision: D9909: [SQLite] add functions to convert user data and tests to user store methods.Nov 16 2023, 2:16 PM

Harbormaster completed remote builds in B24199: Diff 33324.Nov 16 2023, 2:44 PM

kamil published this revision for review.Nov 16 2023, 3:06 PM

kamil added inline comments.

lib/ops/user-store-ops.js
30 ↗	(On Diff #33324)	as described in D9903, implementing key-value table
native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h
66–69 ↗	(On Diff #33324)	JS spec is here: D9796

kamil edited the summary of this revision. (Show Details)Nov 16 2023, 3:06 PM

kamil edited the test plan for this revision. (Show Details)

tomek accepted this revision.Nov 17 2023, 3:12 PM

tomek added inline comments.

lib/ops/user-store-ops.js
30 ↗	(On Diff #33324)	Can we modify this type in a diff that introduces it?
web/cpp/SQLiteQueryExecutorBindings.cpp
19 ↗	(On Diff #33324)	Why is it `WebUserInfo` instead of just `UserInfo`

This revision is now accepted and ready to land.Nov 17 2023, 3:12 PM

WebUserInfo -> UserInfo

lib/ops/user-store-ops.js
30 ↗	(On Diff #33324)	this diff is already landed: D9796
web/cpp/SQLiteQueryExecutorBindings.cpp
19 ↗	(On Diff #33324)	leftover from testing, thanks for catching

Harbormaster completed remote builds in B24265: Diff 33403.Nov 20 2023, 11:53 AM

Closed by commit rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table. · Explain WhyNov 20 2023, 1:48 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5c36d95c18ad: [SQLite] add methods to operate on users table.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

5 lines

SQLiteQueryExecutor.h

5 lines

SQLiteQueryExecutor.cpp

27 lines

entities/

15 lines

web/

database/

_generated/

comm_query_executor.wasm

Diff 33300

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

native/cpp/CommonCpp/DatabaseManagers/entities/UserInfo.h

Loading...

web/database/_generated/comm_query_executor.wasm

Loading...