[lib] Inline reduceLastCommunicatedPlatformDetails
ClosedPublic
Actions

Authored by inka on Nov 8 2023, 6:59 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMM3d94daeb5510: [lib] Inline reduceLastCommunicatedPlatformDetails

Summary

issue: https://linear.app/comm/issue/ENG-5353/inline-reducelastcommunicatedplatformdetails
updateLastCommunicatedPlatformDetailsActionType is dispatched from socket and callServerEndpoint. In both of these we are in the context of one keyserver, so this action is keyserver specific

Test Plan

called updateLastCommunicatedPlatformDetailsActionType, checked that it sets the lastCommunicatedPlatformDetails correctly, chcecked that logInActionTypes sets it correctly.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Nov 8 2023, 6:59 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 8 2023, 6:59 AM

inka published this revision for review.Nov 8 2023, 8:13 AM

Harbormaster completed remote builds in B23910: Diff 32947.Nov 8 2023, 1:08 PM

inka added a parent revision: D9763: [lib] Inline reduceUpdatesCurrentAsOf.Nov 9 2023, 3:34 AM

inka added a child revision: D9803: [lib] Inline reduceConnectionInfo pt.1.Nov 9 2023, 7:30 AM

Rebase

Harbormaster completed remote builds in B24101: Diff 33201.Nov 14 2023, 1:50 AM

michal added inline comments.Nov 14 2023, 5:12 AM

lib/reducers/keyserver-reducer.js
158 ↗	(On Diff #33201)	Do these types match? Isn't one `PlatformDetails` and the other `PlatformDetailsPayload`?
lib/reducers/last-communicated-platform-details-reducer.js
20 ↗	(On Diff #33201)	Is `registerActionTypes.success` handled somewhere?
lib/types/device-types.js
44–47 ↗	(On Diff #33201)	This would be clearer imo (but it doesn't really matter)

Address review, rebase

inka added a subscriber: varun.Nov 16 2023, 1:35 AM

inka added inline comments.

lib/reducers/keyserver-reducer.js
174–185	In ENG-4440 we agreed to leave the register action as is, since it will be replaced and merged with login as part of ENG-4351 @varun is that still true? If so, is there a task that talks about the login / register actions more specifically?