Changes introduced in parent differential allow us to make getSignedIdentityKeysBlob a non-optional argument for socket selectors.
Details
Details
Summary
Test Plan
Run flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 19 2023, 3:35 AM2023-10-19 03:35:27 (UTC-7)
marcin added a parent revision: D9532: Refactor olm accounts lifecycle on web.Oct 19 2023, 3:37 AM2023-10-19 03:37:46 (UTC-7)
marcin added a child revision: D9534: Extract shareable notifications session creation logic to lib.
Harbormaster completed remote builds in B23352: Diff 32181.Oct 19 2023, 3:52 AM2023-10-19 03:52:52 (UTC-7)
Harbormaster completed remote builds in B23356: Diff 32185.Oct 19 2023, 4:01 AM2023-10-19 04:01:54 (UTC-7)
marcin edited the summary of this revision. (Show Details)Oct 19 2023, 4:09 AM2023-10-19 04:09:57 (UTC-7)
This revision is now accepted and ready to land.Oct 23 2023, 9:32 AM2023-10-23 09:32:36 (UTC-7)
Harbormaster completed remote builds in B23506: Diff 32422.Oct 26 2023, 4:50 AM2023-10-26 04:50:13 (UTC-7)
Harbormaster completed remote builds in B24357: Diff 33537.Nov 23 2023, 2:47 AM2023-11-23 02:47:36 (UTC-8)
Closed by commit rCOMMc978bf24d7cf: Enforce getSignedIdentityKeysBlob in socket selectors (authored by marcin). · Explain WhyNov 23 2023, 5:49 AM2023-11-23 05:49:48 (UTC-8)
This revision was automatically updated to reflect the committed changes.