Differential D10106
[keyserver] Update `fetchRoles(threadID: string)` to fetch special_role Authored by atul on Nov 30 2023, 1:04 PM. Tags None Referenced Files
Subscribers
Details We want to update code that fetches from threads or roles to appropriately also fetch roles.special_role so we can include it in the return object. For now, I will leave in the r.special_role = ${specialRoles.DEFAULT_ROLE} AS is_default since I'm intermediately leaving in the isDefault property in RoleInfo. Towards the end of the stack, I will remove this check alongside the property as mentioned in the Linear task. This diff handles role-fetchers.js Part of ENG-5993 Depends on D10969 Ran the query before and after to confirm the results are identical, except with the new special_role field
Diff Detail
Event TimelineComment Actions Updated return type of fetchRoles(...) to Promise<ServerLegacyRoleInfo[]>. fetchRoles(...) is only consumed by updateRoles(...) which disregards special_role field so there was no additional refactoring needed. This diff should be fine to land as-is since it's effectively a noop. |